From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DBDC433F5 for ; Tue, 15 Mar 2022 10:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346911AbiCOKGm convert rfc822-to-8bit (ORCPT ); Tue, 15 Mar 2022 06:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346907AbiCOKGl (ORCPT ); Tue, 15 Mar 2022 06:06:41 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D22A6176 for ; Tue, 15 Mar 2022 03:05:28 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-304-uWX6q3UgNeCPTFM2ROAnlw-1; Tue, 15 Mar 2022 10:05:25 +0000 X-MC-Unique: uWX6q3UgNeCPTFM2ROAnlw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 15 Mar 2022 10:05:24 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Tue, 15 Mar 2022 10:05:24 +0000 From: David Laight To: 'Haowen Bai' , "freude@linux.ibm.com" , "hca@linux.ibm.com" , "gor@linux.ibm.com" , "agordeev@linux.ibm.com" CC: "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] s390: crypto: Use min() instead of doing it manually Thread-Topic: [PATCH v2] s390: crypto: Use min() instead of doing it manually Thread-Index: AQHYOELYjbjSeN2P+kqBKqCPXkmb6KzANxKg Date: Tue, 15 Mar 2022 10:05:24 +0000 Message-ID: References: <1647331264-13853-1-git-send-email-baihaowen@meizu.com> In-Reply-To: <1647331264-13853-1-git-send-email-baihaowen@meizu.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org From: Haowen Bai > Sent: 15 March 2022 08:01 > > Fix following coccicheck warning: > drivers/s390/crypto/zcrypt_ep11misc.c:1112:25-26: WARNING opportunity for min() > > Signed-off-by: Haowen Bai > --- > drivers/s390/crypto/zcrypt_ep11misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/crypto/zcrypt_ep11misc.c b/drivers/s390/crypto/zcrypt_ep11misc.c > index 9ce5a71..bb2a527 100644 > --- a/drivers/s390/crypto/zcrypt_ep11misc.c > +++ b/drivers/s390/crypto/zcrypt_ep11misc.c > @@ -1109,7 +1109,7 @@ static int ep11_wrapkey(u16 card, u16 domain, > if (kb->head.type == TOKTYPE_NON_CCA && > kb->head.version == TOKVER_EP11_AES) { > has_header = true; > - keysize = kb->head.len < keysize ? kb->head.len : keysize; > + keysize = min((size_t)kb->head.len, keysize); I'm sure that would look better as: if (keysize > kb->head.len) keysize = kb->head.len; which makes it much more obvious that the existing value is being limited by a new bound. David > } > > /* request cprb and payload */ > -- > 2.7.4 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)