Re: [PATCH 0/3] crypto: Remove arch-optimized des and des3_ede code

Herbert Xu
2026-04-03T01:07:06Z

On Thu, Mar 26, 2026 at 01:12:42PM -0700, Eric Biggers wrote:
> DES and 3DES are cryptographically obsolete and insecure by modern
> standards. Continuing to maintain highly specific, complex assembly and
> glue code for them, especially when the code isn't testable in QEMU
> (s390 and sparc), is unnecessary and risky.
>
> Thus, this series removes the architecture-optimized DES and 3DES code
> for the three architectures that had it: s390, sparc, and x86.
>
> This series is targeting cryptodev/master.
>
> Eric Biggers (3):
> crypto: s390 - Remove des and des3_ede code
> crypto: sparc - Remove des and des3_ede code
> crypto: x86 - Remove des and des3_ede code
>
> arch/s390/configs/debug_defconfig | 1 -
> arch/s390/configs/defconfig | 1 -
> arch/s390/crypto/Kconfig | 16 -
> arch/s390/crypto/Makefile | 1 -
> arch/s390/crypto/des_s390.c | 502 ------------------
> arch/sparc/crypto/Kconfig | 14 -
> arch/sparc/crypto/Makefile | 2 -
> arch/sparc/crypto/des_asm.S | 419 ---------------
> arch/sparc/crypto/des_glue.c | 482 -----------------
> arch/x86/crypto/Kconfig | 14 -
> arch/x86/crypto/Makefile | 3 -
> arch/x86/crypto/des3_ede-asm_64.S | 831 ------------------------------
> arch/x86/crypto/des3_ede_glue.c | 391 --------------
> 13 files changed, 2677 deletions(-)
> delete mode 100644 arch/s390/crypto/des_s390.c
> delete mode 100644 arch/sparc/crypto/des_asm.S
> delete mode 100644 arch/sparc/crypto/des_glue.c
> delete mode 100644 arch/x86/crypto/des3_ede-asm_64.S
> delete mode 100644 arch/x86/crypto/des3_ede_glue.c
>
>
> base-commit: f9bbd547cfb98b1c5e535aab9b0671a2ff22453a
> --
> 2.53.0

All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt