Re: [PATCH 1/3] crypto: s390 - Remove des and des3_ede code

Eric Biggers
2026-04-09T17:48:22Z

On Thu, Apr 09, 2026 at 10:22:11AM +0200, Holger Dengler wrote:
> Hi Adrian,
>
> On 09/04/2026 09:29, John Paul Adrian Glaubitz wrote:
> > On Thu, 2026-04-09 at 09:08 +0200, Holger Dengler wrote:
> >> On 26/03/2026 21:12, Eric Biggers wrote:
> >>> Since DES and Triple DES are obsolete, there is very little point in
> >>> maintining architecture-optimized code for them. Remove it.
> >>>
> >>> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> >>
> >> Reviewed-by: Holger Dengler <dengler@linux.ibm.com>
> >
> > Wouldn't it actually make sense to keep the old crypto code so we get
> > additional coverage for QEMU's emulation of crypto instructions?
>
> For qemu test coverage on s390, I would prefer the libica [1] test cases,
> which covers mostly all functions codes of the CPACF instructions.
>
> If you want to use the kernel code for testing in addition, you may stay with
> a kernel version before the code removal.
>
> [1] https://github.com/opencryptoki/libica

Yes, the kernel is not a test suite for QEMU. QEMU tests belong in the
QEMU repository itself or in other projects. We don't keep code around
in the kernel purely to exercise functionality in QEMU.

- Eric