From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2B7CD6E61 for ; Wed, 11 Oct 2023 11:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234757AbjJKLvj (ORCPT ); Wed, 11 Oct 2023 07:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbjJKLvj (ORCPT ); Wed, 11 Oct 2023 07:51:39 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3752894; Wed, 11 Oct 2023 04:51:37 -0700 (PDT) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39BBngWC004838; Wed, 11 Oct 2023 11:51:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=bs8gZJqBLh3rDhuyw8lxK62hv4cQ2k+JEkmiR2S8gyk=; b=G2AZG2GVU3SAuHWmW0tC3fyanRz8ZMCJgng8iwUe2zj52Depf7EyrJLMt/zqU/qHpjiO x3N10McczEFghBrcI3MQ48nGPQF25K/MUfU/0QJ2OwSGi42k/ZixA14D7EhIl15ZFsee ieXDygaKMet+FKeK/UxS6hDpLCc6qzAsoPHKEaYBFWrOK0QePmsnSmF21AYLGAf8f8vJ uvoTShzhFsfExhwHV+4h5X8LJN2R3yFoRNV1CuhgIFwGJ+T1Gua0g5ZDfHEaYRF44/pP gvoQ5SgImMYU3HRZASc2nxltAey4oFKsEfRCqY6LDXydBURXaIHeRXahd/wl5Be7VssM Kw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tnu620004-73 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Oct 2023 11:51:32 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39BBdQ4V027851; Wed, 11 Oct 2023 11:42:15 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tntuvgdpj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Oct 2023 11:42:15 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39BAZn0Z024458; Wed, 11 Oct 2023 11:41:32 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tkhnsr0ny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Oct 2023 11:41:32 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39BBfTeO21299942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Oct 2023 11:41:29 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD23220049; Wed, 11 Oct 2023 11:41:29 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4AEE20040; Wed, 11 Oct 2023 11:41:29 +0000 (GMT) Received: from li-978a334c-2cba-11b2-a85c-a0743a31b510.ibm.com (unknown [9.152.224.238]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 11 Oct 2023 11:41:29 +0000 (GMT) Message-ID: Subject: Re: [kvm-unit-tests PATCH 1/9] s390x: topology: Fix report message From: Nina Schoetterl-Glausch To: Janosch Frank , Claudio Imbrenda , Nico =?ISO-8859-1?Q?B=F6hr?= Cc: David Hildenbrand , Thomas Huth , linux-s390@vger.kernel.org, kvm@vger.kernel.org, Andrew Jones , Colton Lewis , Nikos Nikoleris , Sean Christopherson Date: Wed, 11 Oct 2023 13:41:28 +0200 In-Reply-To: <73e51ff7-cdb9-4f28-86ac-7279c6e24919@linux.ibm.com> References: <20231011085635.1996346-1-nsg@linux.ibm.com> <20231011085635.1996346-2-nsg@linux.ibm.com> <434cdea5-e0a8-43d0-a06f-5c4a1990acf7@linux.ibm.com> <57504d05bce665a3855415495c9efc681d28d87d.camel@linux.ibm.com> <73e51ff7-cdb9-4f28-86ac-7279c6e24919@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LyUyf3hxqi_nH1ZMphSEvgqnghT1h9u_ X-Proofpoint-GUID: d97d1Fvk0QUdocKowF24NEgbLazjX3qQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-11_09,2023-10-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310110104 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, 2023-10-11 at 13:30 +0200, Janosch Frank wrote: > On 10/11/23 13:10, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-10-11 at 12:56 +0200, Janosch Frank wrote: > > > On 10/11/23 10:56, Nina Schoetterl-Glausch wrote: > > > > A polarization value of 0 means horizontal polarization. > > > >=20 > > > > Signed-off-by: Nina Schoetterl-Glausch > > >=20 > > > Don't we need to remove the entitlement part? > > > Entitlement is defined as the degree of vertical polarization. > >=20 > > I don't follow. > > We're checking this from the PoP: > > A dedicated CPU is either horizontally or vertically > > polarized. When a dedicated CPU is vertically polar- > > ized, entitlement is always high. Thus, when D is one, > > PP is either 00 binary or 11 binary. >=20 > Ahhhh, I see what's the issue for my brain: Magic values >=20 > Could you please add a patch that introduces an enum for the pp values= =20 > so the report below doesn't need a look into the POP to understand it? Sure can do, probably should also add an enum for type, even if it will only have the one value (IFL) we check for. >=20 > >=20 > > > > --- > > > > s390x/topology.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/s390x/topology.c b/s390x/topology.c > > > > index 69558236..53838ed1 100644 > > > > --- a/s390x/topology.c > > > > +++ b/s390x/topology.c > > > > @@ -275,7 +275,7 @@ static uint8_t *check_tle(void *tc) > > > > if (!cpus->d) > > > > report_skip("Not dedicated"); > > > > else > > > > - report(cpus->pp =3D=3D 3 || cpus->pp =3D=3D 0, "Dedicated CPUs a= re either vertically polarized or have high entitlement"); > > > > + report(cpus->pp =3D=3D 3 || cpus->pp =3D=3D 0, "Dedicated CPUs a= re either horizontally polarized or have high entitlement"); > > > > =20 > > > > return tc + sizeof(*cpus); > > > > } > > >=20 > >=20 >=20