Re: [PATCH v4 1/4] KVM: stats: Separate common stats from architecture specific ones

Marc Zyngier
2021-04-30T12:07:24Z

On Thu, 29 Apr 2021 21:37:37 +0100,
Jing Zhang <jingzhangos@google.com> wrote:

> +struct kvm_vm_stat_common {
> + ulong remote_tlb_flush;
> +};
> +
> +struct kvm_vcpu_stat_common {
> + u64 halt_successful_poll;
> + u64 halt_attempted_poll;
> + u64 halt_poll_invalid;
> + u64 halt_wakeup;
> + u64 halt_poll_success_ns;
> + u64 halt_poll_fail_ns;
> +};

Why can't we make everything a u64? Is there anything that really
needs to be a ulong? On most architectures, they are the same anyway,
so we might as well bite the bullet.

M.

--
Without deviation from the norm, progress is not possible.