From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E911C433ED for ; Wed, 21 Apr 2021 18:35:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3725B613D3 for ; Wed, 21 Apr 2021 18:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241033AbhDUSgL (ORCPT ); Wed, 21 Apr 2021 14:36:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36930 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238438AbhDUSgH (ORCPT ); Wed, 21 Apr 2021 14:36:07 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13LIYld2173924; Wed, 21 Apr 2021 14:35:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=H4FQWRdQUzQzwSbH54CK2GuR16Hmmg8XZEso2oUnrNA=; b=Tmg+MuO+f1QheaueqhgZnugLi7dl1jCaQPP8x0ZHimBxoPmTULn0fZuoRQTCQcF8nV4X zAayagOCvW7pIiaDjQEK8eCVSAkTENNIo6OgHZT99G3U7broyf0FiN8gNhevDQwaaiUW FnhPfNwGVxJSDudGVtkm6MwM4LHKDeFqB0uy+4/ZulCOXmoBGEReXE3qaWr7WiqZyiMs Y9bw+K65tqq/OeTR/qxhMHZzkSViUMrMUhCVu9NumiXxb5Cg5Pxso94vHHPzeuZTBkDO nvVAg18l17sFIDA2s+zq7L6t7/BfvnUSIdGpzOykCEe3y40/Bw3p/FeYKn2rIUU50wTb ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 382sf1g0g0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 14:35:21 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13LIZ2vt174564; Wed, 21 Apr 2021 14:35:20 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 382sf1g0fn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 14:35:20 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13LIZJuq023583; Wed, 21 Apr 2021 18:35:19 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03fra.de.ibm.com with ESMTP id 37yqa89bw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 18:35:19 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13LIZG3q41681348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Apr 2021 18:35:16 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AC5411C04C; Wed, 21 Apr 2021 18:35:16 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 004BF11C04A; Wed, 21 Apr 2021 18:35:16 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.171.22.74]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 21 Apr 2021 18:35:15 +0000 (GMT) Subject: Re: net: bridge: propagate error code and extack from br_mc_disabled_update To: olteanv@gmail.com Cc: andrew@lunn.ch, davem@davemloft.net, f.fainelli@gmail.com, idosch@idosch.org, jiri@resnulli.us, kuba@kernel.org, netdev@vger.kernel.org, nikolay@nvidia.com, roopa@nvidia.com, vladimir.oltean@nxp.com, linux-next@vger.kernel.org, kvm list , linux-s390 References: <20210414192257.1954575-1-olteanv@gmail.com> <20210421181808.5210-1-borntraeger@de.ibm.com> From: Christian Borntraeger Message-ID: Date: Wed, 21 Apr 2021 20:35:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: <20210421181808.5210-1-borntraeger@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: bYhH-jlKvDdy6Ek5vGd6kViOHlpk1Ujz X-Proofpoint-ORIG-GUID: 0Vjk2YeSdJHOQI2SXkMjN_DW-mkDN8Zo Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-21_05:2021-04-21,2021-04-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104210128 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 21.04.21 20:18, Christian Borntraeger wrote: > Whatever version landed in next, according to bisect this broke libvirt/kvms use of bridges: > > > # virsh start s31128001 > error: Failed to start domain 's31128001' > error: Unable to add bridge virbr1 port vnet0: Operation not supported > > # grep vnet0 /var/log/libvirt/libvirtd.log > > 2021-04-21 07:43:09.453+0000: 2460: info : virNetDevTapCreate:240 : created device: 'vnet0' > 2021-04-21 07:43:09.453+0000: 2460: debug : virNetDevSetMACInternal:287 : SIOCSIFHWADDR vnet0 MAC=fe:bb:83:28:01:02 - Success > 2021-04-21 07:43:09.453+0000: 2460: error : virNetDevBridgeAddPort:633 : Unable to add bridge virbr1 port vnet0: Operation not supported > 2021-04-21 07:43:09.466+0000: 2543: debug : udevHandleOneDevice:1695 : udev action: 'add': /sys/devices/virtual/net/vnet0 > > Christian > For reference: ae1ea84b33dab45c7b6c1754231ebda5959b504c is the first bad commit commit ae1ea84b33dab45c7b6c1754231ebda5959b504c Author: Florian Fainelli Date: Wed Apr 14 22:22:57 2021 +0300 net: bridge: propagate error code and extack from br_mc_disabled_update Some Ethernet switches might only be able to support disabling multicast snooping globally, which is an issue for example when several bridges span the same physical device and request contradictory settings. Propagate the return value of br_mc_disabled_update() such that this limitation is transmitted correctly to user-space. Signed-off-by: Florian Fainelli Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller net/bridge/br_multicast.c | 28 +++++++++++++++++++++------- net/bridge/br_netlink.c | 4 +++- net/bridge/br_private.h | 3 ++- net/bridge/br_sysfs_br.c | 8 +------- 4 files changed, 27 insertions(+), 16 deletions(-) not sure if it matters this is on s390. A simple reproducer is virt-install, e.g. virt-install --name test --disk size=12 --memory=2048 --vcpus=2 --location http://ports.ubuntu.com/ubuntu-ports/dists/bionic/main/installer-s390x/