Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

Kamalesh Babulal
2017-01-10T08:49:31Z

On Thursday 08 December 2016 11:38 PM, Josh Poimboeuf wrote:
> The _TIF_ALLWORK_MASK macro automatically includes the least-significant
> 16 bits of the thread_info flags, which is less than obvious and tends
> to create confusion and surprises when reading or modifying the code.
>
> Define the flags explicitly.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

For the version with swapped _TIF_SINGLESTEP and _TIF_NEED_RESCHED
flags.

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

--
cheers,
Kamalesh.