From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7ED52417D3; Fri, 7 Feb 2025 02:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738894540; cv=none; b=fXqAUINJxs4C1TjqZmXk4ahFcCMy5p9J8cfI7orOrAuFTXLu1VOkVt3iQcOs3QhpTuLAPvopHbWIovGq/xW247cZKY3vPbAZvQzNAQIiQtYQyFA2ifVAcQ04DzLpByfuaDXSNEUmPZvtvhlMW5peXCOr09GpGHk7b5wSHbsGDGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738894540; c=relaxed/simple; bh=SWS1Hs+K2WCvk8+cgOLlEWSMg01BIf79cpM9X5fqRs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SCgfEy/UNjgeP4EYL9obKliqkQ7WCwTb+dkLu/xEt+NYwBPuB7zO87B644eJN3ztIkLBaNP0N8x9wrz8POniV/17yNb0QIyEFEHx8lBlGb+2YmGpwl2BU2XKU2sHVCaDHdfp5tG1zFttxV3nfsz8eqyODDYPN7YiYRHp3Hfu+9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fOG/n/HF; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fOG/n/HF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738894539; x=1770430539; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SWS1Hs+K2WCvk8+cgOLlEWSMg01BIf79cpM9X5fqRs0=; b=fOG/n/HFL+xW92b2nT3aXgF9YhIoAxITpKJ/JLWL0oVUpODN4No+s2pN sWDoGCZMfhxGKJorTM1VYB8Xi1w6LZocTH0Z6ziiLfq0TBswWx7Oy8lgN 40rsG+SSCHgNeSz0lrHNIdajoaPm7BGefBa6EpnDqp9eKdEhXht7n5snU Sr8l03cIRKXTaLCdKbCDqqeEdt/zh6sAfY+0OqLfNto/jA67NXa+3Zr8I swOc52fxXSqqbcFJdj2fvdUaLBzVyfAFIUv4hGs/Vf68BdNTfPlev04r7 LZNSaOnoNRcUMbfR4X5xbP1QDvTkOislb4qhMU01wBNe/LGonOj7VEUlS A==; X-CSE-ConnectionGUID: /zcTTFh4QsqeMA9A1YoMgA== X-CSE-MsgGUID: ImG9bJ8JSXqxFI5vr5QhwQ== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="50510603" X-IronPort-AV: E=Sophos;i="6.13,266,1732608000"; d="scan'208";a="50510603" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2025 18:15:38 -0800 X-CSE-ConnectionGUID: amFlnjj3T/2qc320CG/riQ== X-CSE-MsgGUID: U7CRgg7iR4upalKRpijatA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="116013783" Received: from dapengmi-mobl1.ccr.corp.intel.com (HELO [10.124.245.128]) ([10.124.245.128]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2025 18:15:35 -0800 Message-ID: Date: Fri, 7 Feb 2025 10:15:32 +0800 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2 v3] perf test: Change event in perf test 114 perf record test subtest test_leader_sampling To: "Liang, Kan" , Namhyung Kim , Thomas Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, linux-s390@vger.kernel.org, james.clark@linaro.org, agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com References: <20250131102756.4185235-1-tmricht@linux.ibm.com> <20250131102756.4185235-3-tmricht@linux.ibm.com> <9b091546-8178-470b-8904-dc948fd9aa11@linux.intel.com> <688e9a7f-0b98-4f8a-b575-90d7de244589@linux.intel.com> <69f7d048-e7dd-4863-a21f-2d8fafafd280@linux.intel.com> Content-Language: en-US From: "Mi, Dapeng" In-Reply-To: <69f7d048-e7dd-4863-a21f-2d8fafafd280@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/6/2025 10:25 PM, Liang, Kan wrote: > > On 2025-02-06 12:42 a.m., Mi, Dapeng wrote: >> On 2/4/2025 11:55 PM, Liang, Kan wrote: >>> On 2025-02-03 10:42 p.m., Namhyung Kim wrote: >>>> Add Kan and Dapeng to CC. >>>> >>>> Thanks, >>>> Namhyung >>>> >>>> >>>> On Fri, Jan 31, 2025 at 11:27:56AM +0100, Thomas Richter wrote: >>>>> On s390 the event instructions can not be used for recording. >>>>> This event is only supported by perf stat. >>>>> >>>>> Change the event from instructions to cycles in >>>>> subtest test_leader_sampling. >>>>> >>>>> Signed-off-by: Thomas Richter >>>>> Suggested-by: James Clark >>>>> Reviewed-by: James Clark >>>>> --- >>>>> tools/perf/tests/shell/record.sh | 10 +++++----- >>>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh >>>>> index fe2d05bcbb1f..ba8d873d3ca7 100755 >>>>> --- a/tools/perf/tests/shell/record.sh >>>>> +++ b/tools/perf/tests/shell/record.sh >>>>> @@ -231,7 +231,7 @@ test_cgroup() { >>>>> >>>>> test_leader_sampling() { >>>>> echo "Basic leader sampling test" >>>>> - if ! perf record -o "${perfdata}" -e "{instructions,instructions}:Su" -- \ >>>>> + if ! perf record -o "${perfdata}" -e "{cycles,cycles}:Su" -- \ >>>>> perf test -w brstack 2> /dev/null >>> As a non-precise test, using cycles instead should be fine. But we >>> should never use it for precise test, e.g., with p. Because cycles is a >>> non-precise event. It would not surprise me if there is a skid when >>> reading two cycles events at the point when the event overflow occurs. >>> >>> Reviewed-by: Kan Liang >> Kan, I suppose you mean only the case without counter snapshot, right? With >> counter snapshot's help, there would be same period even for non-precise >> events, right? > No, the counter-snapshot doesn't help. That's why I suggested to not > utilize it via enabling the modifier p. It should work for most of the > cases. But it's not 100% guaranteed for some non-precise events that the > same period is got at overflow. Since it's a test that could be run > everywhere, the occasional false alarm would just bring troubles. > > Without p, it falls back to the traditional way of handling the sampling > read. In the PMI handler, the global control is disabled first, then all > the counters are read. The value may not be very accurate, since it's > stopped at the PMI handler, not the counter overflow. But because of the > global control, all the counters stop at the same time. The skid would > be the same. The test should work. Got it. Thanks for explaining. > > Thanks, > Kan >> >>> Thanks, >>> Kan >>> >>>>> then >>>>> echo "Leader sampling [Failed record]" >>>>> @@ -243,15 +243,15 @@ test_leader_sampling() { >>>>> while IFS= read -r line >>>>> do >>>>> # Check if the two instruction counts are equal in each record >>>>> - instructions=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="instructions:") print $(i-1)}') >>>>> - if [ $(($index%2)) -ne 0 ] && [ ${instructions}x != ${prev_instructions}x ] >>>>> + cycles=$(echo $line | awk '{for(i=1;i<=NF;i++) if($i=="cycles:") print $(i-1)}') >>>>> + if [ $(($index%2)) -ne 0 ] && [ ${cycles}x != ${prev_cycles}x ] >>>>> then >>>>> - echo "Leader sampling [Failed inconsistent instructions count]" >>>>> + echo "Leader sampling [Failed inconsistent cycles count]" >>>>> err=1 >>>>> return >>>>> fi >>>>> index=$(($index+1)) >>>>> - prev_instructions=$instructions >>>>> + prev_cycles=$cycles >>>>> done < $script_output >>>>> echo "Basic leader sampling test [Success]" >>>>> } >>>>> -- >>>>> 2.48.1 >> The code changes look good for me. >> >>