From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: [PATCH 15/17] s390/debug: Improve a size determination in debug_raw_header_fn() References: <566ABCD9.1060404@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Sat, 3 Sep 2016 14:36:09 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini List-ID: From: Markus Elfring Date: Fri, 2 Sep 2016 14:34:22 +0200 * Replace the specification of a data type by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Return a constant directly without storing the desired value in a local variable. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index 6792a9c..ff8e705 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -1380,11 +1380,8 @@ static int debug_raw_header_fn(debug_info_t * id, struct debug_view *view, int area, debug_entry_t * entry, char *out_buf) { - int rc; - - rc = sizeof(debug_entry_t); - memcpy(out_buf, entry, sizeof(debug_entry_t)); - return rc; + memcpy(out_buf, entry, sizeof(*entry)); + return sizeof(*entry); } /* -- 2.9.3