From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:61542 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726608AbfGRMCm (ORCPT ); Thu, 18 Jul 2019 08:02:42 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6IC2ZGw111654 for ; Thu, 18 Jul 2019 08:02:41 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ttra18bn6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 08:02:36 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 13:02:28 +0100 Subject: Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind References: <20190718080903.22622-1-daniel.vetter@ffwll.ch> From: Jens Remus Date: Thu, 18 Jul 2019 14:02:23 +0200 MIME-Version: 1.0 In-Reply-To: <20190718080903.22622-1-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: Sender: linux-s390-owner@vger.kernel.org List-ID: To: Daniel Vetter , Intel Graphics Development Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman , Nicolas Pitre , Martin Hostettler , Adam Borowski , Mikulas Patocka , Daniel Vetter , Sam Ravnborg Am 18.07.2019 um 10:09 schrieb Daniel Vetter: > Not really harmful not to, but also not harm in grabbing the lock. And > this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: > More locking checks"). > > Reported-by: Jens Remus > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Nicolas Pitre > Cc: Martin Hostettler > Cc: Adam Borowski > Cc: Mikulas Patocka > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Sam Ravnborg > --- > drivers/tty/vt/vt.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Thank you for the quick fix! Looks fine to me. Did test with cat as well as our dump2tar utility. The warning is gone. Tested-by: Jens Remus Regards, Jens Remus -- Linux on Z and z/VSE Development & Service (D3229) IBM Systems & Technology Group, Pure Systems & Modular Software Development IBM Data Privacy Statement: https://www.ibm.com/privacy/us/en/ IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Matthias Hartmann Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294