Re: [PATCH v3 23/26] of, numa: return -EINVAL when no numa-node-id is found

Jonathan Cameron
2024-08-02T14:01:45Z

On Thu, 1 Aug 2024 09:08:23 +0300
Mike Rapoport <rppt@kernel.org> wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Currently of_numa_parse_memory_nodes() returns 0 if no "memory" node in
> device tree contains "numa-node-id" property. This makes of_numa_init()
> to return "success" despite no NUMA nodes were actually parsed and set
> up.
>
> arch_numa workarounds this by returning an error if numa_nodes_parsed is
> empty.
>
> numa_memblks however would WARN() in such case and since it will be used
> by arch_numa shortly, such warning is not desirable.
>
> Make sure of_numa_init() returns -EINVAL when no NUMA node information
> was found in the device tree.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>