Re: [kvm-unit-tests PATCH v8 3/6] s390x: lib: fix stfl wrapper asm

David Hildenbrand
2020-01-21T09:18:07Z

On 20.01.20 19:42, Claudio Imbrenda wrote:
> the stfl wrapper in lib/s390x/asm/facility.h was lacking the "memory"
> clobber in the inline asm.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> lib/s390x/asm/facility.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/s390x/asm/facility.h b/lib/s390x/asm/facility.h
> index 5103dd4..e34dc2c 100644
> --- a/lib/s390x/asm/facility.h
> +++ b/lib/s390x/asm/facility.h
> @@ -24,7 +24,7 @@ static inline bool test_facility(int nr)
>
> static inline void stfl(void)
> {
> - asm volatile(" stfl 0(0)\n");
> + asm volatile(" stfl 0(0)\n" : : : "memory");
> }
>
> static inline void stfle(uint8_t *fac, unsigned int len)
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb