From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h References: <20180116021818.24791-1-deepa.kernel@gmail.com> <20180116021818.24791-3-deepa.kernel@gmail.com> From: Christian Borntraeger Date: Tue, 6 Mar 2018 13:48:22 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Archive: List-Post: To: Arnd Bergmann Cc: Deepa Dinamani , Thomas Gleixner , John Stultz , Mark Rutland , "open list:RALINK MIPS ARCHITECTURE" , Peter Zijlstra , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , sparclinux , devel@driverdev.osuosl.org, linux-s390 , y2038 Mailman List , Helge Deller , the arch/x86 maintainers , sebott@linux.vnet.ibm.com, "James E.J. Bottomley" , Will Deacon , Ingo Molnar , oprofile-list@lists.sf.net, Catalin Marinas , Robert Richter , Chris Metcalf , Peter Oberparleiter , Arnaldo Carvalho de Melo , Julian Wiedmann , Steven Rostedt , Ursula Braun , gerald.schaefer@de.ibm.com, Parisc List , gregkh , cohuck@redhat.com, Linux Kernel Mailing List , Ralf Baechle , Jan Hoeppner , Stefan Haberland , Martin Schwidefsky , linuxppc-dev , David Miller List-ID: On 03/06/2018 01:46 PM, Arnd Bergmann wrote: > On Mon, Mar 5, 2018 at 10:30 AM, Christian Borntraeger > wrote: >> On 01/16/2018 03:18 AM, Deepa Dinamani wrote: >>> All the current architecture specific defines for these >>> are the same. Refactor these common defines to a common >>> header file. >>> >>> The new common linux/compat_time.h is also useful as it >>> will eventually be used to hold all the defines that >>> are needed for compat time types that support non y2038 >>> safe types. New architectures need not have to define these >>> new types as they will only use new y2038 safe syscalls. >>> This file can be deleted after y2038 when we stop supporting >>> non y2038 safe syscalls. >> >> You are now include a from several asm files >> ( >> arch/arm64/include/asm/stat.h >> arch/s390/include/asm/elf.h >> arch/x86/include/asm/ftrace.h >> arch/x86/include/asm/sys_ia32.h >> ) >> It works, and it is done in many places, but it looks somewhat weird. >> Would it make sense to have an asm-generic/compate-time.h instead? Asking for >> opinions here. > > I don't think we have such a rule. If a header file is common to all > architectures (i.e. no architecture uses a different implementation), > it should be in include/linux rather than include/asm-generic, regardless > of whether it can be used by assembler files or not. > >>> --- a/drivers/s390/net/qeth_core_main.c >>> +++ b/drivers/s390/net/qeth_core_main.c >>> @@ -32,7 +32,7 @@ >>> #include >>> #include >>> #include >>> -#include >>> +#include >>> #include >>> #include >>> #include >> >> Can you move that into the other includes (where all the other includes are. > > Good catch, this is definitely a rule we have ;-) FWIW, this was also broken for arch/x86/include/asm/sys_ia32.h