From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47394 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725843AbgKSHev (ORCPT ); Thu, 19 Nov 2020 02:34:51 -0500 Subject: Re: [PATCH 6/6] s390/ctcm: Use GFP_ATOMIC in ctcmpc_tx(). References: <20201118105317.605671-1-bigeasy@linutronix.de> <20201118105317.605671-7-bigeasy@linutronix.de> From: Julian Wiedmann Message-ID: Date: Thu, 19 Nov 2020 09:34:41 +0200 MIME-Version: 1.0 In-Reply-To: <20201118105317.605671-7-bigeasy@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Sebastian Andrzej Siewior , linux-s390@vger.kernel.org Cc: Karsten Graul , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner On 18.11.20 12:53, Sebastian Andrzej Siewior wrote: > gfp_type() uses in_interrupt() to figure out the correct GFP mask. > > The usage of in_interrupt() in drivers is phased out and Linus clearly > requested that code which changes behaviour depending on context should > either be separated or the context be conveyed in an argument passed by the > caller, which usually knows the context. > > ctcmpc_tx() is used as net_device_ops::ndo_start_xmit. This callback is > invoked with disabled bottom halves. > > Use GFP_ATOMIC for memory allocation in ctcmpc_tx(). > Remove gfp_type() since the last user is gone. > > Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Julian Wiedmann