Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones

Paolo Bonzini
2021-06-11T10:51:34Z

On 11/06/21 08:57, Christian Borntraeger wrote:
>> @@ -755,12 +750,12 @@ struct kvm_vcpu_arch {
>>   };
>>   struct kvm_vm_stat {
>> +    struct kvm_vm_stat_generic generic;
>
> s390 does not have remote_tlb_flush. I guess this does not hurt?

It would have to be accounted in gmap_flush_tlb, but there is no struct
kvm in there. A slightly hackish possibility would be to include the
gmap by value (instead of by pointer) in struct kvm, and then use
container_of.

This reminds me that I have never asked you why the gmap code is not in
arch/s390/kvm, and also that there is no code in QEMU that uses
KVM_VM_S390_UCONTROL or KVM_S390_VCPU_FAULT. It would be nice to have
some testcases for that, and also for KVM_S390_VCPU_FAULT with regular
virtual machines... or to remove the code if it's unused.

Thanks,

Paolo