From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Mueller Subject: Re: [PATCH 05/12] s390/css: expose the AIV facility Date: Thu, 18 Jan 2018 13:02:45 +0100 Message-ID: References: <20180116200217.211897-1-borntraeger@de.ibm.com> <20180116200217.211897-6-borntraeger@de.ibm.com> <29f77b94-a5e1-178d-2364-9dcf77dc9096@redhat.com> Reply-To: David Hildenbrand Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <29f77b94-a5e1-178d-2364-9dcf77dc9096@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Christian Borntraeger , Cornelia Huck Cc: mimu@linux.vnet.ibm.com, KVM , linux-s390 , Janosch Frank List-ID: On 17.01.18 16:19, David Hildenbrand wrote: > On 16.01.2018 21:02, Christian Borntraeger wrote: >> From: Michael Mueller >> >> The patch exposes the Adapter Interruption Virtualization facility (AIV) >> of the general channel subsystem characteristics. >> >> Signed-off-by: Michael Mueller >> Reviewed-by: Halil Pasic >> Reviewed-by: Christian Borntraeger >> Signed-off-by: Christian Borntraeger >> --- >> arch/s390/include/asm/css_chars.h | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/s390/include/asm/css_chars.h b/arch/s390/include/asm/css_chars.h >> index a478eb61aaf7..fb56fa3283a2 100644 >> --- a/arch/s390/include/asm/css_chars.h >> +++ b/arch/s390/include/asm/css_chars.h >> @@ -20,7 +20,9 @@ struct css_general_char { >> u32 aif_tdd : 1; /* bit 56 */ >> u32 : 1; >> u32 qebsm : 1; /* bit 58 */ >> - u32 : 8; >> + u32 : 2; >> + u32 aiv : 1; /* bit 61 */ >> + u32 : 5; >> u32 aif_osa : 1; /* bit 67 */ >> u32 : 12; >> u32 eadm_rf : 1; /* bit 80 */ >> > "Expose" sounds like actually forwarding something / enabling a bit. Expose here basically means to make sth. visible what was already available. > Wonder if this can be squashed with another patch? > > Or rename to something like "define" ... I don't plan to change anything. > Thanks, Michael