Re: [PATCH v2 07/20] KVM: s390: KVM-specific bitfields and helper functions

Claudio Imbrenda
2025-09-17T12:52:00Z

On Wed, 17 Sep 2025 14:18:22 +0200
Heiko Carstens <hca@linux.ibm.com> wrote:

> On Wed, Sep 10, 2025 at 08:07:33PM +0200, Claudio Imbrenda wrote:
> > Add KVM-s390 specific bitfields and helper functions to manipulate DAT
> > tables.
> >
> > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> > ---
> > arch/s390/kvm/dat.h | 693 ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 693 insertions(+)
> > create mode 100644 arch/s390/kvm/dat.h
>
> ...
>
> > +static inline struct page_table *dat_alloc_empty_pt(void)
> > +{
> > + return dat_alloc_pt(_PAGE_INVALID, 0);
> > +}
>
> This is calling a function which get's introduced with a later
> patch. It is not harmful, since all of this code is still unused, but
> still odd.

yeah but this should not be here, I'll move it to the appropriate patch

thanks for spotting this