From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:59137 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731485AbgK0RSc (ORCPT ); Fri, 27 Nov 2020 12:18:32 -0500 References: <3E05451B-A9CD-4719-99D0-72750A304044@amazon.com> From: "Catangiu, Adrian Costin" Subject: Re: [PATCH v2] drivers/virt: vmgenid: add vm generation id driver Message-ID: Date: Fri, 27 Nov 2020 19:17:53 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: base64 List-ID: To: Alexander Graf , Christian Borntraeger , "Jason A. Donenfeld" , Jann Horn Cc: Willy Tarreau , "MacCarthaigh, Colm" , Andy Lutomirski , "Theodore Y. Ts'o" , Eric Biggers , "open list:DOCUMENTATION" , kernel list , "Woodhouse, David" , "bonzini@gnu.org" , "Singh, Balbir" , "Weiss, Radu" , "oridgar@gmail.com" , "ghammer@redhat.com" , Jonathan Corbet , Greg Kroah-Hartman , "Michael S. Tsirkin" , Qemu Developers , KVM list , Michal Hocko , "Rafael J. Wysocki" , Pavel Machek , Linux API , "mpe@ellerman.id.au" , linux-s390 , "areber@redhat.com" , Pavel Emelyanov , Andrey Vagin , Mike Rapoport , Dmitry Safonov <0x7f454c46@gmail.com>, Pavel Tikhomirov , "gil@azul.com" , "asmehra@redhat.com" , "dgunigun@redhat.com" , "vijaysun@ca.ibm.com" Ck9uIDE4LzExLzIwMjAgMTI6MzAsIEFsZXhhbmRlciBHcmFmIHdyb3RlOgo+Cj4KPiBPbiAxNi4x MS4yMCAxNjozNCwgQ2F0YW5naXUsIEFkcmlhbiBDb3N0aW4gd3JvdGU6Cj4+IC0gRnV0dXJlIGlt cHJvdmVtZW50cwo+Pgo+PiBJZGVhbGx5IHdlIHdvdWxkIHdhbnQgdGhlIGRyaXZlciB0byByZWdp c3RlciBpdHNlbGYgYmFzZWQgb24gZGV2aWNlcycKPj4gX0NJRCBhbmQgbm90IF9ISUQsIGJ1dCB1 bmZvcnR1bmF0ZWx5IEkgY291bGRuJ3QgZmluZCBhIHdheSB0byBkbyB0aGF0Lgo+PiBUaGUgcHJv YmxlbSBpcyB0aGF0IEFDUEkgZGV2aWNlIG1hdGNoaW5nIGlzIGRvbmUgYnkKPj4gJ19fYWNwaV9t YXRjaF9kZXZpY2UoKScgd2hpY2ggZXhjbHVzaXZlbHkgbG9va3MgYXQKPj4gJ2FjcGlfaGFyZHdh cmVfaWQgKmh3aWQnLgo+Pgo+PiBUaGVyZSBpcyBhIHBhdGggZm9yIHBsYXRmb3JtIGRldmljZXMg dG8gbWF0Y2ggb24gX0NJRCB3aGVuIF9ISUQgaXMKPj4gJ1BSUDAwMDEnIC0gYnV0IHRoaXMgaXMg bm90IHRoZSBjYXNlIGZvciB0aGUgUWVtdSB2bWdlbmlkIGRldmljZS4KPj4KPj4gR3VpZGFuY2Ug YW5kIGhlbHAgaGVyZSB3b3VsZCBiZSBncmVhdGx5IGFwcHJlY2lhdGVkLgo+Cj4gVGhhdCBvbmUg aXMgcHJldHR5IGltcG9ydGFudCBJTUhPLiBIb3cgYWJvdXQgdGhlIGZvbGxvd2luZyAocHJvYmFi bHkKPiBwcmV0dHkgbWFuZ2xlZCkgcGF0Y2g/IFRoYXQgc2VlbXMgdG8gd29yayBmb3IgbWUuIFRo ZSBBQ1BJIGNoYW5nZQo+IHdvdWxkIG9idmlvdXNseSBuZWVkIHRvIGJlIGl0cyBvd24gc3RhbmQg YWxvbmUgY2hhbmdlIGFuZCBuZWVkcyBwcm9wZXIKPiBhc3Nlc3NtZW50IHdoZXRoZXIgaXQgY291 bGQgcG9zc2libHkgYnJlYWsgYW55IGV4aXN0aW5nIHN5c3RlbXMuCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9hY3BpL2J1cy5jIGIvZHJpdmVycy9hY3BpL2J1cy5jCj4gaW5kZXggMTY4MmY4YjQ1 NGEyLi40NTI0NDNkNzlkODcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9hY3BpL2J1cy5jCj4gKysr IGIvZHJpdmVycy9hY3BpL2J1cy5jCj4gQEAgLTc0OCw3ICs3NDgsNyBAQCBzdGF0aWMgYm9vbCBf X2FjcGlfbWF0Y2hfZGV2aWNlKHN0cnVjdCBhY3BpX2RldmljZQo+ICpkZXZpY2UsCj4gwqDCoMKg wqDCoMKgwqDCoCAvKiBGaXJzdCwgY2hlY2sgdGhlIEFDUEkvUE5QIElEcyBwcm92aWRlZCBieSB0 aGUgY2FsbGVyLiAqLwo+IMKgwqDCoMKgwqDCoMKgwqAgaWYgKGFjcGlfaWRzKSB7Cj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGZvciAoaWQgPSBhY3BpX2lkczsgaWQtPmlkWzBdIHx8IGlkLT5j bHM7IGlkKyspIHsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChpZC0+aWRb MF0gJiYgIXN0cmNtcCgoY2hhciAqKWlkLT5pZCwgaHdpZC0+aWQpKQo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgaWYgKGlkLT5pZFswXSAmJiAhc3RybmNtcCgoY2hhciAqKWlkLT5p ZCwgaHdpZC0+aWQsCj4gQUNQSV9JRF9MRU4gLSAxKSkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gb3V0X2FjcGlfbWF0Y2g7Cj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgaWYgKGlkLT5jbHMgJiYgX19hY3BpX21hdGNoX2RldmljZV9jbHMo aWQsIGh3aWQpKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290 byBvdXRfYWNwaV9tYXRjaDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0L3ZtZ2VuaWQuYyBi L2RyaXZlcnMvdmlydC92bWdlbmlkLmMKPiBpbmRleCA3NWE3ODdkYThhYWQuLjBiZmE0MjJjZjA5 NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpcnQvdm1nZW5pZC5jCj4gKysrIGIvZHJpdmVycy92 aXJ0L3ZtZ2VuaWQuYwo+IEBAIC0zNTYsNyArMzU2LDggQEAgc3RhdGljIHZvaWQgdm1nZW5pZF9h Y3BpX25vdGlmeShzdHJ1Y3QgYWNwaV9kZXZpY2UKPiAqZGV2aWNlLCB1MzIgZXZlbnQpCj4gwqB9 Cj4KPiDCoHN0YXRpYyBjb25zdCBzdHJ1Y3QgYWNwaV9kZXZpY2VfaWQgdm1nZW5pZF9pZHNbXSA9 IHsKPiAtwqDCoMKgIHsiUUVNVVZHSUQiLCAwfSwKPiArwqDCoMKgIC8qIFRoaXMgcmVhbGx5IGlz IFZNX0dlbl9Db3VudGVyLCBidXQgd2UgY2FuIG9ubHkgbWF0Y2ggOAo+IGNoYXJhY3RlcnMgKi8K PiArwqDCoMKgIHsiVk1fR0VOX0MiLCAwfSwKPiDCoMKgwqDCoCB7IiIsIDB9LAo+IMKgfTsKPgoK TG9va3MgbGVnaXQuIEkgY2FuIHByb3Bvc2UgYSBwYXRjaCB3aXRoIGl0LCBidXQgaG93IGRvIHdl IHZhbGlkYXRlIGl0CmRvZXNuJ3QgYnJlYWsgYW55IGRldmljZXM/CgoKPj4gKzIpIEFTWU5DIHNp bXBsaWZpZWQgZXhhbXBsZTo6Cj4+ICsKPj4gK8KgwqDCoCB2b2lkIGhhbmRsZV9pb19vbl92bWdl bmZkKGludCB2bWdlbmZkKQo+PiArwqDCoMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgIHVuc2lnbmVk IGdlbmlkOwo+PiArCj4+ICvCoMKgwqDCoMKgwqDCoCAvLyBiZWNhdXNlIG9mIFZNIGdlbmVyYXRp b24gY2hhbmdlLCB3ZSBuZWVkIHRvIHJlYnVpbGQgd29ybGQKPj4gK8KgwqDCoMKgwqDCoMKgIHJl c2VlZF9hcHBfZW52KCk7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIC8vIHJlYWQgbmV3IGdlbiBJ RCAtIHdlIG5lZWQgaXQgdG8gY29uZmlybSB3ZSd2ZSBoYW5kbGVkIHVwZGF0ZQo+PiArwqDCoMKg wqDCoMKgwqAgcmVhZChmZCwgJmdlbmlkLCBzaXplb2YoZ2VuaWQpKTsKPgo+IFRoaXMgaXMgcmFj eSBpbiBjYXNlIHR3byBjb25zZWN1dGl2ZSBzbmFwc2hvdHMgaGFwcGVuLiBUaGUgcmVhZCBuZWVk cwo+IHRvIGdvIGJlZm9yZSB0aGUgcmVzZWVkLgo+ClN3aXRjaGVkIHRoZW0gYXJvdW5kIGxpa2Ug eW91IHN1Z2dlc3QgdG8gYXZvaWQgY29uZnVzaW9uLgoKQnV0IEkgZG9uJ3Qgc2VlIGEgcHJvYmxl bSB3aXRoIHRoaXMgcmFjZS4gVGhlIGlkZWEgaGVyZSBpcyB0byB0cmlnZ2VyCnJlc2VlZF9hcHBf ZW52KCkgd2hpY2ggZG9lc24ndCBkZXBlbmQgb24gdGhlIGdlbmVyYXRpb24gY291bnRlciB2YWx1 ZS4KV2hldGhlciBpdCBnZXRzIGluY3JlbWVudGVkIG9uY2Ugb3IgTiB0aW1lcyBpcyBpcnJlbGV2 YW50LCB3ZSdyZSBqdXN0CmludGVyZXN0ZWQgdGhhdCB3ZSBwYXVzZSBleGVjdXRpb24gYW5kIHJl c2VlZCBiZWZvcmUgcmVzdW1pbmcgKGluCmJldHdlZW4gdGhlc2UsIHdoZXRoZXIgTiBvciBNIGdl bmVyYXRpb24gY2hhbmdlcyBpcyB0aGUgc2FtZSB0aGluZykuCgo+PiArMykgTWFwcGVkIG1lbW9y eSBwb2xsaW5nIHNpbXBsaWZpZWQgZXhhbXBsZTo6Cj4+ICsKPj4gK8KgwqDCoCAvKgo+PiArwqDC oMKgwqAgKiBhcHAvbGlicmFyeSBmdW5jdGlvbiB0aGF0IHByb3ZpZGVzIGNhY2hlZCBzZWNyZXRz Cj4+ICvCoMKgwqDCoCAqLwo+PiArwqDCoMKgIGNoYXIgKiBzYWZlX2NhY2hlZF9zZWNyZXQoYXBw X2RhdGFfdCAqYXBwKQo+PiArwqDCoMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgIGNoYXIgKnNlY3Jl dDsKPj4gK8KgwqDCoMKgwqDCoMKgIHZvbGF0aWxlIHVuc2lnbmVkICpjb25zdCBnZW5pZF9wdHIg PSBnZXRfdm1nZW5pZF9tYXBwaW5nKGFwcCk7Cj4+ICvCoMKgwqAgYWdhaW46Cj4+ICvCoMKgwqDC oMKgwqDCoCBzZWNyZXQgPSBfX2NhY2hlZF9zZWNyZXQoYXBwKTsKPj4gKwo+PiArwqDCoMKgwqDC oMKgwqAgaWYgKHVubGlrZWx5KCpnZW5pZF9wdHIgIT0gYXBwLT5jYWNoZWRfZ2VuaWQpKSB7Cj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8vIHJlYnVpbGQgd29ybGQgdGhlbiBjb25maXJtIHRo ZSBnZW5pZCB1cGRhdGUgKHRocnUgd3JpdGUpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJl YnVpbGRfY2FjaGVzKGFwcCk7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYXBwLT5j YWNoZWRfZ2VuaWQgPSAqZ2VuaWRfcHRyOwo+Cj4gVGhpcyBpcyByYWN5IGFnYWluLiBZb3UgbmVl ZCB0byByZWFkIHRoZSBnZW5pZCBiZWZvcmUgcmVidWlsZCBhbmQgc2V0Cj4gaXQgaGVyZS4KPgpJ IGRvbid0IHNlZSB0aGUgcmFjZS4gR2VuIGNvdW50ZXIgaXMgcmVhZCBmcm9tIHZvbGF0aWxlIG1h cHBlZCBtZW0sIG9uCmRldGVjdGVkIGNoYW5nZSB3ZSByZWJ1aWxkIHdvcmxkLCBjb25maXJtIHRo ZSB1cGRhdGUgYmFjayB0byB0aGUgZHJpdmVyCnRoZW4gcmVzdGFydCB0aGUgbG9vcC4gTG9vcCB3 aWxsIGJyZWFrIHdoZW4gbm8gbW9yZSBjaGFuZ2VzIGhhcHBlbi4KCj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGFja192bWdlbmlkX3VwZGF0ZShhcHApOwo+PiArCj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGdvdG8gYWdhaW47Cj4+ICvCoMKgwqDCoMKgwqDCoCB9Cj4+ICsKPj4gK8KgwqDC oMKgwqDCoMKgIHJldHVybiBzZWNyZXQ7Cj4+ICvCoMKgwqAgfQo+PiArCgo+PiArCj4+ICtzdGF0 aWMgaW50IHZtZ2VuaWRfY2xvc2Uoc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZp bGUpCj4+ICt7Cj4+ICvCoMKgwqAgc3RydWN0IGZpbGVfZGF0YSAqZmlsZV9kYXRhID0gZmlsZS0+ cHJpdmF0ZV9kYXRhOwo+PiArwqDCoMKgIHN0cnVjdCBkZXZfZGF0YSAqcHJpdiA9IGZpbGVfZGF0 YS0+ZGV2X2RhdGE7Cj4+ICsKPj4gK8KgwqDCoCBpZiAoZmlsZV9kYXRhLT5hY2tlZF9nZW5fY291 bnRlciAhPSBwcml2LT5nZW5lcmF0aW9uX2NvdW50ZXIpCj4+ICvCoMKgwqDCoMKgwqDCoCB2bWdl bmlkX3B1dF9vdXRkYXRlZF93YXRjaGVycyhwcml2KTsKPgo+IElzIHRoaXMgcmFjeT8gQ291bGQg dGhlcmUgYmUgYSBzbmFwc2hvdCBub3RpZmljYXRpb24gY29taW5nIGJldHdlZW4KPiB0aGUgYnJh bmNoIGFuZCB0aGUgcHV0Pwo+ClRoaXMgaXMgaW5kZWVkIHJhY3ksIHdpbGwgZml4IGl0IGluIHBh dGNoIHYzLgo+PiArwqDCoMKgIGF0b21pY19kZWMoJnByaXYtPndhdGNoZXJzKTsKPj4gK8KgwqDC oCBrZnJlZShmaWxlX2RhdGEpOwo+PiArCj4+ICvCoMKgwqAgcmV0dXJuIDA7Cj4+ICt9Cgo+PiAr c3RhdGljIHNzaXplX3Qgdm1nZW5pZF93cml0ZShzdHJ1Y3QgZmlsZSAqZmlsZSwgY29uc3QgY2hh ciBfX3VzZXIKPj4gKnVidWYsCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2l6 ZV90IGNvdW50LCBsb2ZmX3QgKnBwb3MpCj4+ICt7Cj4+ICvCoMKgwqAgc3RydWN0IGZpbGVfZGF0 YSAqZmlsZV9kYXRhID0gZmlsZS0+cHJpdmF0ZV9kYXRhOwo+PiArwqDCoMKgIHN0cnVjdCBkZXZf ZGF0YSAqcHJpdiA9IGZpbGVfZGF0YS0+ZGV2X2RhdGE7Cj4+ICvCoMKgwqAgdW5zaWduZWQgaW50 IGFja2VkX2dlbl9jb3VudDsKPj4gKwo+PiArwqDCoMKgIC8qIGRpc2FsbG93IHBhcnRpYWwgd3Jp dGVzICovCj4+ICvCoMKgwqAgaWYgKGNvdW50ICE9IHNpemVvZihhY2tlZF9nZW5fY291bnQpKQo+ PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+ICvCoMKgwqAgaWYgKGNvcHlfZnJv bV91c2VyKCZhY2tlZF9nZW5fY291bnQsIHVidWYsIGNvdW50KSkKPj4gK8KgwqDCoMKgwqDCoMKg IHJldHVybiAtRUZBVUxUOwo+PiArwqDCoMKgIC8qIHdyb25nIGdlbi1jb3VudGVyIGFja25vd2xl ZGdlZCAqLwo+PiArwqDCoMKgIGlmIChhY2tlZF9nZW5fY291bnQgIT0gcHJpdi0+Z2VuZXJhdGlv bl9jb3VudGVyKQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+ICsKPj4gK8Kg wqDCoCBpZiAoZmlsZV9kYXRhLT5hY2tlZF9nZW5fY291bnRlciAhPSBwcml2LT5nZW5lcmF0aW9u X2NvdW50ZXIpIHsKPj4gK8KgwqDCoMKgwqDCoMKgIC8qIHVwZGF0ZSBsb2NhbCB2aWV3IG9mIFVV SUQgKi8KPj4gK8KgwqDCoMKgwqDCoMKgIGZpbGVfZGF0YS0+YWNrZWRfZ2VuX2NvdW50ZXIgPSBh Y2tlZF9nZW5fY291bnQ7Cj4+ICvCoMKgwqDCoMKgwqDCoCB2bWdlbmlkX3B1dF9vdXRkYXRlZF93 YXRjaGVycyhwcml2KTsKPgo+IFNhbWUgcXVlc3Rpb24gaGVyZTogV2hhdCBpZiB0aGVyZSBpcyBh IG5vdGlmaWNhdGlvbiBiZXR3ZWVuIHRoZSBicmFuY2gKPiBhbmQgdGhlIHB1dD8KPgpSaWdodCwg cmFjeSBoZXJlIGFzIHdlbGwuIFdpbGwgZml4IGluIHBhdGNoIHYzLgoKClRoYW5rcywKCkFkcmlh bi4KCgoKCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgKFJvbWFuaWEpIFMuUi5MLiByZWdpc3Rl cmVkIG9mZmljZTogMjdBIFNmLiBMYXphciBTdHJlZXQsIFVCQzUsIGZsb29yIDIsIElhc2ksIElh c2kgQ291bnR5LCA3MDAwNDUsIFJvbWFuaWEuIFJlZ2lzdGVyZWQgaW4gUm9tYW5pYS4gUmVnaXN0 cmF0aW9uIG51bWJlciBKMjIvMjYyMS8yMDA1Lgo=