From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:4852 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727118AbfLJL2z (ORCPT ); Tue, 10 Dec 2019 06:28:55 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBABRZWj015584 for ; Tue, 10 Dec 2019 06:28:54 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2wrt9y4y2x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Dec 2019 06:28:53 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Dec 2019 11:28:52 -0000 Subject: Re: [kvm-unit-tests PATCH v3 5/9] s390x: Library resources for CSS tests References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-6-git-send-email-pmorel@linux.ibm.com> <66233a15-7cc4-45b5-d930-abbedbd0729d@redhat.com> <23770c1c-8aba-85ef-09a1-346393bb90d6@redhat.com> <64632e2f-5519-0323-c4ea-47582e3591f8@redhat.com> From: Pierre Morel Date: Tue, 10 Dec 2019 12:28:49 +0100 MIME-Version: 1.0 In-Reply-To: <64632e2f-5519-0323-c4ea-47582e3591f8@redhat.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thomas Huth , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com On 2019-12-10 12:27, Thomas Huth wrote: > On 10/12/2019 12.22, Pierre Morel wrote: >> >> >> On 2019-12-10 11:28, Thomas Huth wrote: >>> On 10/12/2019 11.07, Pierre Morel wrote: >>>> >>>> >>>> On 2019-12-09 12:49, Thomas Huth wrote: >>>>> On 06/12/2019 17.26, Pierre Morel wrote: >>>>>> These are the include and library utilities for the css tests patch >>>>>> series. >>>>>> >>>>>> Signed-off-by: Pierre Morel >>>>>> --- >>>>>>    lib/s390x/css.h      | 259 >>>>>> +++++++++++++++++++++++++++++++++++++++++++ >>>>>>    lib/s390x/css_dump.c | 156 ++++++++++++++++++++++++++ >>>>>>    2 files changed, 415 insertions(+) >>>>>>    create mode 100644 lib/s390x/css.h >>>>>>    create mode 100644 lib/s390x/css_dump.c >>>>>> >>>>>> diff --git a/lib/s390x/css.h b/lib/s390x/css.h >>>>>> new file mode 100644 >>>>>> index 0000000..6f19bb5 >>>>>> --- /dev/null >>>>>> +++ b/lib/s390x/css.h >>>>> [...] >>>>>> +/* Debug functions */ >>>>>> +char *dump_pmcw_flags(uint16_t f); >>>>>> +char *dump_scsw_flags(uint32_t f); >>>>>> +#undef DEBUG >>>>>> +#ifdef DEBUG >>>>>> +void dump_scsw(struct scsw *); >>>>>> +void dump_irb(struct irb *irbp); >>>>>> +void dump_schib(struct schib *sch); >>>>>> +struct ccw *dump_ccw(struct ccw *cp); >>>>>> +#else >>>>>> +static inline void dump_scsw(struct scsw *scsw) {} >>>>>> +static inline void dump_irb(struct irb *irbp) {} >>>>>> +static inline void dump_pmcw(struct pmcw *p) {} >>>>>> +static inline void dump_schib(struct schib *sch) {} >>>>>> +static inline void dump_orb(struct orb *op) {} >>>>>> +static inline struct ccw *dump_ccw(struct ccw *cp) >>>>>> +{ >>>>>> +    return NULL; >>>>>> +} >>>>>> +#endif >>>>> >>>>> I'd prefer to not have a "#undef DEBUG" (or "#define DEBUG") statement >>>> >>>> Anyway hawfull! >>>> >>>>> in the header here - it could trigger unexpected behavior with other >>>>> files that also use a DEBUG macro. >>>>> >>>>> Could you please declare the prototypes here and move the "#else" part >>>>> to the .c file instead? Thanks! >>>> >>>> What if I use a CSS_DEBUG here instead of a simple DEBUG definition? >>>> >>>> It can be enabled or not by defining CSS_ENABLED ahead of the >>>> include...? >>> >>> Why does it have to be in the header and not in the .c file? >> >> I too mean in the C file. :) >> above the include. > > Well, as long as we don't have any generic "#undef DEBUG" statements in > the header anymore, I think I don't care too much either way. Yes, it was not good, shoudn't have survive my first tests. Thanks Pierre > > Thomas > -- Pierre Morel IBM Lab Boeblingen