From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A378259B6E for ; Mon, 22 Jan 2024 17:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945045; cv=none; b=ViZGu4xTfqgEekdZsrP4RmhfoWDmr6+LlTcWmRhfionAqycPcljlqkuHe+OzqV7xgdc9YwclAIJJQbo//PxBKLgI2HM03ifkPhst+sKHz38FmhpSCvCGr5Qp72O2ocdFpZgQza3fJ2JETgxV7a4JJsINfDSnhJq8ISQeptLw2RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945045; c=relaxed/simple; bh=m8kPm/j1LsdrYXYN+YQDJ7r2rWymD6BOjcIeRkuQtHQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Badi3aLRKNmy9G9ouU2AUwRIhCPTtJEEa/S4S9n/WvkzW6fxNkH3fLb3AZdTX9bCx1uiaWtkBInWuuZEr71Ml3gq2nB+fR3LHOZaHwnPKai4cgJNipLYeTsmbnDuV8lnYMSRY9/8A01rMWBfcIoO98lt3CcbfhY3pV3H/dn/dKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BfY0v7rd; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BfY0v7rd" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2cd0f4797aaso32961941fa.0 for ; Mon, 22 Jan 2024 09:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1705945038; x=1706549838; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=s9fIVUDS4JPjZqnrZBBkM7zrxIcZN1SBne4vcNi0x/g=; b=BfY0v7rdDpiZmmLYYWoDuF0YGEp4K60GdHWqajby71boVGC+Cx4MCVWe2LEGjUDLSF W3PgujIF3cQnKaeevPdoqwDC4p6jFFYyZC89Tcpww66tRVUTjpmO19rM2IVK4h9YavVy 9mbH4cJuneSFhXQkUvwKzqhmvxCqSEmMIQKFGPsvDMxGvVVTPzJrdeEn6xME3pz3EIFF XbobTiM2JA5pM8Bov8H4Bd+3voY0WLU95PnjM5MZmHUxd5ZwsYQxSJVmgnb5HCsSfxYt pEbW56jgInd/J19p/bpeQ9bRZEezjH6CP2j93CvjnuNANu4L4357o86RMqe23ct+Si3A rf1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705945038; x=1706549838; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=s9fIVUDS4JPjZqnrZBBkM7zrxIcZN1SBne4vcNi0x/g=; b=LnO22wORGCvFlNx1SqKo+zTVZDuSwLuLviADyazi/4uM9MPITn5a7ByECQnV7iJwLn FRY52ZzesEjJrClW8En2CBbxw0MMNl3tQlOvwyolHBJgEukXSJU497gHM3bq6m+yp5QI ISD54W6i1xli9zzBMYKqKIWQ395ZQ4ISCc0bQGCw6HazsCCvVkT6xdV0o4P7aEMqHVjQ YHxXbuqLzJdSaLe5yG5MrwSKu1CsuZTHHz/pOueV42CN16B4aa/IuBR57DgugTXsl8Oy Vett6VsF7TCKKu7lLwzUR03hYlXhIKsujG+0JRP6I4NoD5q2MXDtRQCmR/xSLUss9IPk frCQ== X-Gm-Message-State: AOJu0YzEeLlvEE7zEdxZ7iGgMFEw8Vs5WEwIt+vKMta2zjtSTPBUbjaE 4yc+mzK5HpUXSup/UBcsM6JnixUzKuXLZuBRlJ8BQtUCDLywAiFp1PPbMq3yTQg= X-Google-Smtp-Source: AGHT+IGtMtcqWkvVLEoaIeMoHtV2CsA0V+GTi7mnCKwegjzg2YjeUcTa13uMM6pmGiJG+dRvm4j+ag== X-Received: by 2002:a2e:a4a7:0:b0:2cc:ceb2:372a with SMTP id g7-20020a2ea4a7000000b002ccceb2372amr1541040ljm.96.1705945038673; Mon, 22 Jan 2024 09:37:18 -0800 (PST) Received: from ?IPv6:2804:30c:974:ac00:1b02:e2fd:23be:79bc? ([2804:30c:974:ac00:1b02:e2fd:23be:79bc]) by smtp.gmail.com with ESMTPSA id j26-20020a056e02221a00b00361a166564csm3015628ilf.4.2024.01.22.09.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 09:37:18 -0800 (PST) Message-ID: Subject: Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable From: Marcos Paulo de Souza To: Shuah Khan , Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org Date: Mon, 22 Jan 2024 14:37:09 -0300 In-Reply-To: <5aceb855-2862-4d53-b27b-50e2956e099b@linuxfoundation.org> References: <20240112-send-lp-kselftests-v6-0-79f3e9a46717@suse.com> <20240112-send-lp-kselftests-v6-1-79f3e9a46717@suse.com> <5aceb855-2862-4d53-b27b-50e2956e099b@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-01-22 at 10:15 -0700, Shuah Khan wrote: > On 1/12/24 10:43, Marcos Paulo de Souza wrote: > > Add TEST_GEN_MODS_DIR variable for kselftests. It can point to > > a directory containing kernel modules that will be used by > > selftest scripts. > >=20 > > The modules are built as external modules for the running kernel. > > As a result they are always binary compatible and the same tests > > can be used for older or newer kernels. > >=20 > > The build requires "kernel-devel" package to be installed. > > For example, in the upstream sources, the rpm devel package > > is produced by "make rpm-pkg" > >=20 > > The modules can be built independently by > >=20 > > =C2=A0=C2=A0 make -C tools/testing/selftests/livepatch/ > >=20 > > or they will be automatically built before running the tests via > >=20 > > =C2=A0=C2=A0 make -C tools/testing/selftests/livepatch/ run_tests > >=20 > > Note that they are _not_ built when running the standalone > > tests by calling, for example, ./test-state.sh. > >=20 > > Along with TEST_GEN_MODS_DIR, it was necessary to create a new > > install > > rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would > > copy the entire TEST_GEN_MODS_DIR directory to the destination, > > even > > the files created by Kbuild to compile the modules. The new install > > rule copies only the .ko files, as we would expect the gen_tar to > > work. > >=20 > > Reviewed-by: Joe Lawrence > > Reviewed-by: Petr Mladek > > Signed-off-by: Marcos Paulo de Souza > > --- > > =C2=A0 Documentation/dev-tools/kselftest.rst |=C2=A0 4 ++++ > > =C2=A0 tools/testing/selftests/lib.mk=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 26 +++++++++++++++++++++- > > ---- >=20 >=20 > Hi Marcos, >=20 > I would like the doc patch and lib.mk patch separate. If lib.mk needs > changes > we don't have to touch the doc patch. Hi Shuah, on patch 2/3 you also said that you would like to have the documentation changes split in the future, and that you picked the changes into a testing branch. Does it also applies to this patch? Do I need to resend the three patches and separate the documentation part into a new one, or can I apply this rationale to future changes to lib.mk? Sorry, I'm confused. Thanks in advance, Marcos >=20 > thanks, > -- Shuah