From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:21434 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgDVI7q (ORCPT ); Wed, 22 Apr 2020 04:59:46 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03M8XaU4053017 for ; Wed, 22 Apr 2020 04:59:45 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 30ggxqy3cr-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Apr 2020 04:59:45 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Apr 2020 09:58:49 +0100 Subject: Re: [kvm-unit-tests PATCH v5 02/10] s390x: Use PSW bits definitions in cstart References: <1582200043-21760-1-git-send-email-pmorel@linux.ibm.com> <1582200043-21760-3-git-send-email-pmorel@linux.ibm.com> From: Pierre Morel Date: Wed, 22 Apr 2020 10:59:37 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Sender: linux-s390-owner@vger.kernel.org List-ID: To: David Hildenbrand , Janosch Frank , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, thuth@redhat.com, cohuck@redhat.com On 2020-04-22 09:44, David Hildenbrand wrote: > >>> diff --git a/s390x/cstart64.S b/s390x/cstart64.S >>> index 45da523..2885a36 100644 >>> --- a/s390x/cstart64.S >>> +++ b/s390x/cstart64.S >>> @@ -12,6 +12,7 @@ >>> */ >>> #include >>> #include >>> +#include >>> >>> .section .init >>> >>> @@ -214,19 +215,19 @@ svc_int: >>> >>> .align 8 >>> reset_psw: >>> - .quad 0x0008000180000000 >>> + .quad PSW_EXCEPTION_MASK >> >> That won't work, this is a short PSW and you're removing the short >> indication here. Notice the 0008 at the front. hum... :( > > Good catch! Guess it would have bailed out when testing. > > Yes it does. Sorry. -- Pierre Morel IBM Lab Boeblingen