Re: [PATCH] livepatch: Remove klp_arch_set_pc() and asm/livepatch.h

Christophe Leroy
2022-06-02T12:50:47Z

Hi Petr,

Le 23/05/2022 à 17:15, Petr Mladek a écrit :
> On Mon 2022-05-23 06:51:47, Christophe Leroy wrote:
>>
>>
>> Le 29/03/2022 à 13:22, Petr Mladek a écrit :
>>> On Mon 2022-03-28 08:26:48, Christophe Leroy wrote:
>>>> All three versions of klp_arch_set_pc() do exactly the same: they
>>>> call ftrace_instruction_pointer_set().
>>>>
>>>> Call ftrace_instruction_pointer_set() directly and remove
>>>> klp_arch_set_pc().
>>>>
>>>> As klp_arch_set_pc() was the only thing remaining in asm/livepatch.h
>>>> on x86 and s390, remove asm/livepatch.h
>>>>
>>>> livepatch.h remains on powerpc but its content is exclusively used
>>>> by powerpc specific code.
>>>>
>>>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>>>
>>> Acked-by: Petr Mladek <pmladek@suse.com>
>>>
>>> I am going to take it via livepatch/livepatch.git for 5.19. We are
>>> already in the middle of the merge window and this is not critical.
>>>
>>
>> I haven't seen it in linux-next.
>>
>> Do you still plan to take it for 5.19 ?
>
> Thanks a lot for pointing this out. I have completely forgot about
> this patch /o\
>
> I have just pushed it into livepatching/livepatching.git,
> branch for-5.19/cleanup.
>
> I am going to create pull request for 5.19 by the end of this week
> after it gets a spin in linux-next.
>

I can't see it yet in linus mainline tree. Any issue ?

Thanks
Christophe