From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFD9C433EF for ; Mon, 11 Oct 2021 07:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B852460D07 for ; Mon, 11 Oct 2021 07:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234526AbhJKHrK (ORCPT ); Mon, 11 Oct 2021 03:47:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37110 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234129AbhJKHrK (ORCPT ); Mon, 11 Oct 2021 03:47:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633938310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LSuc4UVJmiHSzAiziKZ1KJ+0nObIwFoDvepNLe3NpSw=; b=Jg9T50qPI8ir7dUSh5VJrM6xUR9GZtAXH8e7FPMW4sPCjpAUv+cf9mf9f6D4tW9/2cYwGy o3PGqMNQOYIEFknNdETsrO6nMWsoxaKrA55dpi7rWoPLyZ4fnI6HiBQkOIMBsU6DHMY9L9 C4YjYIJ4As0HcudtyDBDm8Sc/RLeCcs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-jP2you0oN-GukCXU6yCvgQ-1; Mon, 11 Oct 2021 03:45:09 -0400 X-MC-Unique: jP2you0oN-GukCXU6yCvgQ-1 Received: by mail-wr1-f69.google.com with SMTP id 41-20020adf802c000000b00161123698e0so708293wrk.12 for ; Mon, 11 Oct 2021 00:45:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LSuc4UVJmiHSzAiziKZ1KJ+0nObIwFoDvepNLe3NpSw=; b=6qxDO/SYWWGi3mmDx2fjlSJ5vb+iXymoqzf9cX2xP6/J3qsp1Yg5YWyOwYDVyXf221 paMVgk3F+1t2XcDIg/iIHLlQXMplRaceMIrUSwt3PkVoy0R0koNBBBe9z53u8Eij2KrL Pe+qGdltbt7Z72ji6Z/dJvG2D+FRMVagKvQ81uvumS3BCa8TWTLA1GAkPk5eBDGX+P7f i/7WEDAJX6j+gbZcb0NLu3Z2pcN0ZSBwwCfWjf7jCpNVgmsineK6Ok7kSpO7dmE7bYdb QyqQWW9ZBB5o+h4adzZLha02q+4M2Kqh69Gz0k0AjIbUTCN/LKCOj2ADr6A8Pzps1kO0 DmCA== X-Gm-Message-State: AOAM530pRiDQk065E6uilk5sVTuMGtgN7WdmtBqHIMfKabs+6X/AyooZ n12F2ZqQEHryFHQxoH0Kz9LNAT93UrbNy3EMLndryDJNp6hVUjvxFMF5BHiixbfeVJju8Uw2PAG hF+zVNaK/ksRvekNg0iB85Ywpx20fi6oeNlVAIbXUU2Ld7/jte/ZGhWlK4TfTRFKhBxp+5Q== X-Received: by 2002:a7b:c193:: with SMTP id y19mr16530351wmi.125.1633938307853; Mon, 11 Oct 2021 00:45:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEXteg820Qpm2pfAUuKRxfpLikImqdkOGT+Q3tHDW6PBFaytT3M1sCv60MWzuhDbyX4uY+3g== X-Received: by 2002:a7b:c193:: with SMTP id y19mr16530313wmi.125.1633938307467; Mon, 11 Oct 2021 00:45:07 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64ba.dip0.t-ipconnect.de. [91.12.100.186]) by smtp.gmail.com with ESMTPSA id f15sm3877814wrt.38.2021.10.11.00.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Oct 2021 00:45:07 -0700 (PDT) Subject: Re: [RFC PATCH v1 6/6] KVM: s390: Add a routine for setting userspace CPU state To: Eric Farman , Christian Borntraeger , Janosch Frank , Cornelia Huck , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Jason Herne Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20211008203112.1979843-1-farman@linux.ibm.com> <20211008203112.1979843-7-farman@linux.ibm.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 11 Oct 2021 09:45:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211008203112.1979843-7-farman@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 08.10.21 22:31, Eric Farman wrote: > This capability exists, but we don't record anything when userspace > enables it. Let's refactor that code so that a note can be made in > the debug logs that it was enabled. > > Signed-off-by: Eric Farman > --- > arch/s390/kvm/kvm-s390.c | 6 +++--- > arch/s390/kvm/kvm-s390.h | 9 +++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 33d71fa42d68..48ac0bd05bee 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -2487,8 +2487,8 @@ long kvm_arch_vm_ioctl(struct file *filp, > case KVM_S390_PV_COMMAND: { > struct kvm_pv_cmd args; > > - /* protvirt means user sigp */ > - kvm->arch.user_cpu_state_ctrl = 1; > + /* protvirt means user cpu state */ > + kvm_s390_set_user_cpu_state_ctrl(kvm); > r = 0; > if (!is_prot_virt_host()) { > r = -EINVAL; > @@ -3801,7 +3801,7 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu, > vcpu_load(vcpu); > > /* user space knows about this interface - let it control the state */ > - vcpu->kvm->arch.user_cpu_state_ctrl = 1; > + kvm_s390_set_user_cpu_state_ctrl(vcpu->kvm); > > switch (mp_state->mp_state) { > case KVM_MP_STATE_STOPPED: > diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h > index 57c5e9369d65..36f4d585513c 100644 > --- a/arch/s390/kvm/kvm-s390.h > +++ b/arch/s390/kvm/kvm-s390.h > @@ -208,6 +208,15 @@ static inline int kvm_s390_user_cpu_state_ctrl(struct kvm *kvm) > return kvm->arch.user_cpu_state_ctrl != 0; > } > > +static inline void kvm_s390_set_user_cpu_state_ctrl(struct kvm *kvm) > +{ > + if (kvm->arch.user_cpu_state_ctrl) > + return; > + > + VM_EVENT(kvm, 3, "%s", "ENABLE: Userspace CPU state control"); > + kvm->arch.user_cpu_state_ctrl = 1; > +} > + > /* implemented in pv.c */ > int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc); > int kvm_s390_pv_create_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb