From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C59823E229 for ; Tue, 16 Sep 2025 08:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758010804; cv=none; b=BOy5IvveaaR9LxcX7wswk1o6NZZy2/cwuBZ1a1uBBUvouz1cedTcjO5vOZ4okbtikmFhmRKOxcjqdbjHR2MOVTnB6Kt1Mj2NkFfzj1rOTD0ULjnxKFR2NWyVUwcscZF5+HMbWgN4etAznM5bUtKlji6xWzUonzP0JA0eiSRGujw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758010804; c=relaxed/simple; bh=wyzFXdhH71/K6R4ozNwpypG96FdPPhKK1bsIffaUOAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XllRdqRQWjlFqTzMV3CbY0/Gy2TtR4OmdreQFwvph39+7RU+fkgCoqAwpcLvpGdWMU+2Qpm4a9ToP3z22LFzPh+q8+XfhynoCPlTtZVCXAy72VAXLVIcnTW1pqp3JrJyhDdEUFfDFLwuU49Riso9Yri5VbwszRBHxzqT585sjT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cKl8mF+B; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cKl8mF+B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758010802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NzL2N1DLwKqBJMwL8CAS9ydZTfmXfd5ccrcFe6t3UgE=; b=cKl8mF+B2HrIPufSGUrOV9ztHLqZHbhhCz+Fi+9OTAMuT5ZKdV9zr27FEvhQzDP5KYyaM0 j+J+ZSg4XbfmvPZ/A/M8k66Cz16KPJwabzPaOYo7uVyZNRWYhAVkYuysFm9T2+/8ofdX0/ atjWij8Tc1PfdxBwc2vsuz2lhBSEj5A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-f7xhDMXiPgKDAAoJVdgPyg-1; Tue, 16 Sep 2025 04:20:01 -0400 X-MC-Unique: f7xhDMXiPgKDAAoJVdgPyg-1 X-Mimecast-MFC-AGG-ID: f7xhDMXiPgKDAAoJVdgPyg_1758010800 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b9a856d58so7029675e9.0 for ; Tue, 16 Sep 2025 01:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758010800; x=1758615600; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NzL2N1DLwKqBJMwL8CAS9ydZTfmXfd5ccrcFe6t3UgE=; b=w8OWtpMt3nzbeT21MvS3qOh6MnObJWuTLBOE9WiWmrfWEQj6GNtyxtgTTcMu1Dbmem dF0moEBPHhV6luwfBEODSJ9l9acbyTzfCs4nzBmxIIMcsjsrwhAaa40fKZ17QZybKgUB yoyjCXDqyiVJzkfpVqHgPKiO787NLnpdjmLbL5R0PdyKgZtXIvb5VvXf5NUXeI+uyBbj x+ppblOYOobGT/nssaqztLTkBVtZKusqZca7uliMg1C+YFVrKDCWCWZNQ10CiafR5OUh WxVwy+dWSh4PMu3lA2rVpppIR1vl5OSk5gYuFkJe7Izp/LleE+cZucnkUM66/AWPk+k2 4nrw== X-Forwarded-Encrypted: i=1; AJvYcCUoh6uUdcBNXVA9mBD8pL0SewHWre61sFOFtuIqYsKtkNxVbZD/lEMXhXeE/+cYThXQeFVyaENMZ0Gy@vger.kernel.org X-Gm-Message-State: AOJu0YzsWz2bd9Y6vyP/0kUisXBEZEw4xJfB98L3a9B1td+tRnQVldse W1tVOr4im/EdWng3KsOI7mVB6RNwyHdWOOK18iA2/UgCw6H/A4euplyWSr/+bCOkhPSFjBh5hno yxBQzh5wwJR7PAsWlL+u+ZohjFpuz4dfY04jxc7veih3dZPVIOjl5xPoadbywahU= X-Gm-Gg: ASbGncu6K53YuUZCr4u4WIRbUKSqomnoQstBJswd8D93g7nePRqb1o5mcr6IsugI4Me wXc47hh8/Fat3B6k/UY4MwIpxTjwLpbap8sxKDa7FEbpAgQguNxCF3ysnmrgjAta5+yWig1nxhJ cI0iGf0MVqAU9iI1jAw9zl7A41trJ8B9xOoPmNXX6QpU2qD9HCGKE1zp8uhT+x8C9E2oFP0RLMq xz/GrbSY8EiaF6dOBII9bkFNTJo6F8f4uxbW5IspIbFc8nWXOZ9mSsajq9gq4MnN11XP6ULyYhJ nfXAQBRLRcpopQcoZYA15q1UoiohchIgp+QEX5DZ0n48lADC3r2j/OOucgxoPT+vB32K8t7KB6r 3HZY8EJlufvOd X-Received: by 2002:a05:6000:23ca:b0:3ea:5f76:3f7a with SMTP id ffacd0b85a97d-3ea5f764a5dmr4367622f8f.22.1758010799646; Tue, 16 Sep 2025 01:19:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEno2K+NdUW6UjWVLC6LxT9P7Qfem/6TR6gFdG8F5R9GArEc4/f2xtzeLzakkVXchgcRbliwQ== X-Received: by 2002:a05:6000:23ca:b0:3ea:5f76:3f7a with SMTP id ffacd0b85a97d-3ea5f764a5dmr4367594f8f.22.1758010799204; Tue, 16 Sep 2025 01:19:59 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e9a066366fsm10432408f8f.44.2025.09.16.01.19.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 01:19:58 -0700 (PDT) Message-ID: Date: Tue, 16 Sep 2025 10:19:56 +0200 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 13/14] dibs: Move data path to dibs layer To: Alexandra Winter , "D. Wythe" , Dust Li , Sidraya Jayagond , Wenjia Zhang , David Miller , Jakub Kicinski , Eric Dumazet , Andrew Lunn Cc: Julian Ruess , Aswin Karuvally , Halil Pasic , Mahanta Jambigi , Tony Lu , Wen Gu , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Simon Horman , Eric Biggers , Ard Biesheuvel , Herbert Xu , Harald Freudenberger , Konstantin Shkolnyy References: <20250911194827.844125-1-wintera@linux.ibm.com> <20250911194827.844125-14-wintera@linux.ibm.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250911194827.844125-14-wintera@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/11/25 9:48 PM, Alexandra Winter wrote: > +static void __dibs_lo_unregister_dmb(struct dibs_lo_dev *ldev, > + struct dibs_lo_dmb_node *dmb_node) > +{ > + /* remove dmb from hash table */ > + write_lock_bh(&ldev->dmb_ht_lock); > + hash_del(&dmb_node->list); > + write_unlock_bh(&ldev->dmb_ht_lock); > + > + clear_bit(dmb_node->sba_idx, ldev->sba_idx_mask); > + kvfree(dmb_node->cpu_addr); > + kfree(dmb_node); I see the above comes directly from existing code, but it's not clear to me where (and if) dmb_node->cpu_addr is vmalloc()ed (as opposed to kmalloc()ed). Could you consider switching to kfree() (if possible/applicable) and/or add a describing comment if not? Thanks, Paolo