From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2] smc: return booleans instead of integers References: <20180119205450.GA10785@embeddedgus> From: Ursula Braun Date: Mon, 22 Jan 2018 12:58:10 +0100 MIME-Version: 1.0 In-Reply-To: <20180119205450.GA10785@embeddedgus> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: "Gustavo A. R. Silva" , "David S. Miller" Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Fix function using_ipsec as suggested by Ursula Braun. > - Update subject line. > > net/smc/smc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/smc/smc.h b/net/smc/smc.h > index 0bee9d1..6328565 100644 > --- a/net/smc/smc.h > +++ b/net/smc/smc.h > @@ -253,12 +253,12 @@ static inline int smc_uncompress_bufsize(u8 compressed) > static inline bool using_ipsec(struct smc_sock *smc) > { > return (smc->clcsock->sk->sk_policy[0] || > - smc->clcsock->sk->sk_policy[1]) ? 1 : 0; > + smc->clcsock->sk->sk_policy[1]) ? true : false; > } > #else > static inline bool using_ipsec(struct smc_sock *smc) > { > - return 0; > + return false; > } > #endif > Thanks, Gustavo. I have added the patch to our local repository. It will be part of one of my next patch sets to be sent to Dave Miller. Regards, Ursula