From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x References: <20190730100112.18205-1-thuth@redhat.com> <20190730100112.18205-3-thuth@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 30 Jul 2019 21:06:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org List-ID: To: Christian Borntraeger , Thomas Huth , kvm@vger.kernel.org, Janosch Frank Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, David Hildenbrand , Cornelia Huck , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Shuah Khan , Peter Xu On 30/07/19 16:57, Christian Borntraeger wrote: > While this fixes the test (and the migration does work fine), it still > means that s390x overindicates the dirty bit for sparsely populated > 1M segments. It is just a performance issue, but maybe we should try > to get this fixed. Not sure what to do here to remember us about this, > adding this as expected fail? if it's only on the first access after enabling dirty logging, that shouldn't be that bad? Paolo