From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B80369D73 for ; Fri, 10 Jul 2026 04:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783657488; cv=none; b=tkx3i6SwivB1UnVPLfkdPkZxT5/klfuMK/P7LG3MH/n5fQZyT3Mj/XruVufxBseEkKix245JBGEN0Rn9nQK5yYhdJAS20+LAXCi3p+8uMAKkgjxj6B9/LdMErclPBJQu20MJdtOkDlDM2SY3qNDZcXESZejBa7I8nmMHw+jUc1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783657488; c=relaxed/simple; bh=5vGYUhOMuE2kcV5F2F/QyOUeKJT4pi9j/suBd/skgfU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JtVKLjDe4LDpiE0yKh8DNhEZDtJjir2D+C6U2XbRN1d/sqqC0/dV5ctLvBy3dgBpwzAMNdL4V3cS7pmjsJHtL2mNh4X1gPKs+wWStYHGJP4ZDk3YPMOQ0OerUPu4Ey6aGWoVtfGhBXCAEaofHUupi4liwZ5hELNaxYl3N8fRfVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LJGfn04S; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LJGfn04S" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783657473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=48gm6OSOL1SSOirHXZF2Z0M3HkLWpnOs0tv5n6E0teY=; b=LJGfn04SGFnL8UXhLSB+52PBN7KESuIh0Km2DPDIXEWCwpVcPBjjL7pNuROWfkO3PbuKb4 s5by1GL/2w+WeQFh6Fp0wbpSxEQCnzYDYPz5NsvnR03XOVlKjLSD4XfRhpaKmrfuJJHrAX kh/MORb3lQmU3ylwe47f8YvgkCuI88Q= Date: Thu, 9 Jul 2026 21:24:25 -0700 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH rdma-next 13/13] RDMA/selftests: Add rxe_netns_names test To: Jiri Pirko , linux-rdma@vger.kernel.org, "yanjun.zhu@linux.dev" Cc: cgroups@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kselftest@vger.kernel.org, jgg@ziepe.ca, leon@kernel.org, parav@nvidia.com, mbloch@nvidia.com, cmeiohas@nvidia.com, roman.gushchin@linux.dev, bvanassche@acm.org, zyjzyj2000@gmail.com, shuah@kernel.org, tj@kernel.org, mkoutny@suse.com, hannes@cmpxchg.org, alibuda@linux.alibaba.com, dust.li@linux.alibaba.com, sidraya@linux.ibm.com, wenjia@linux.ibm.com References: <20260709095532.855647-1-jiri@resnulli.us> <20260709095532.855647-14-jiri@resnulli.us> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20260709095532.855647-14-jiri@resnulli.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2026/7/9 2:55, Jiri Pirko 写道: > From: Jiri Pirko > > Add a kselftest script that exercises per-netns RDMA device naming > with RXE. Cover duplicate names across namespaces, move conflict > handling, move-with-rename, and same-namespace rename requests. This is a very comprehensive test suite for the per-netns RDMA device naming infra. I especially appreciate the inclusion of the 'TEST_TEARDOWN_RETURN' case—ensuring that the kernel's automatic renaming and fallback mechanics work seamlessly during netns deletion is crucial for long-term stability. One minor thing to clean up before pushing to the tree: the script declares 'ktap_set_plan 7' but actually defines 6 distinct test cases in the execution block. I will fix this plan count to 6 to avoid any "bad plan" warnings in automated CI frameworks (like KernelCI). Aside from that, the cleanup paths and setup tracking are solid. Thanks for adding this. Reviewed-by: Zhu Yanjun Zhu Yanjun > > Signed-off-by: Jiri Pirko > --- > tools/testing/selftests/rdma/Makefile | 3 +- > tools/testing/selftests/rdma/config | 2 + > .../testing/selftests/rdma/rxe_netns_names.sh | 282 ++++++++++++++++++ > 3 files changed, 286 insertions(+), 1 deletion(-) > create mode 100755 tools/testing/selftests/rdma/rxe_netns_names.sh > > diff --git a/tools/testing/selftests/rdma/Makefile b/tools/testing/selftests/rdma/Makefile > index 07af7f15c1bf..a91c14c45006 100644 > --- a/tools/testing/selftests/rdma/Makefile > +++ b/tools/testing/selftests/rdma/Makefile > @@ -3,6 +3,7 @@ TEST_PROGS := rxe_rping_between_netns.sh \ > rxe_ipv6.sh \ > rxe_socket_with_netns.sh \ > rxe_test_NETDEV_UNREGISTER.sh \ > - rxe_sent_rcvd_bytes.sh > + rxe_sent_rcvd_bytes.sh \ > + rxe_netns_names.sh > > include ../lib.mk > diff --git a/tools/testing/selftests/rdma/config b/tools/testing/selftests/rdma/config > index 4ffb814e253b..e1ff54ec0f57 100644 > --- a/tools/testing/selftests/rdma/config > +++ b/tools/testing/selftests/rdma/config > @@ -1,3 +1,5 @@ > CONFIG_TUN > CONFIG_VETH > +CONFIG_DUMMY > +CONFIG_NET_NS > CONFIG_RDMA_RXE > diff --git a/tools/testing/selftests/rdma/rxe_netns_names.sh b/tools/testing/selftests/rdma/rxe_netns_names.sh > new file mode 100755 > index 000000000000..a7e57706fdff > --- /dev/null > +++ b/tools/testing/selftests/rdma/rxe_netns_names.sh > @@ -0,0 +1,282 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Exercise RDMA device name handling across network namespaces. > + > +source "$(dirname "$0")/../kselftest/ktap_helpers.sh" > + > +NAME_PREFIX="rxe_netns_names_$$" > +NETDEV_PREFIX="rxn$$" > +NS1="${NAME_PREFIX}ns1" > +NS2="${NAME_PREFIX}ns2" > +RXE_A="${NAME_PREFIX}rxe_a" > +RXE_B="${NAME_PREFIX}rxe_b" > +RXE_SAME="${NAME_PREFIX}rxe_same" > +RXE_NEW="${NAME_PREFIX}rxe_new" > +DUMMY_A="${NETDEV_PREFIX}a" > +DUMMY_B="${NETDEV_PREFIX}b" > +OLD_MODE="" > +MODE_CHANGED=0 > +MODS=("dummy" "rdma_rxe") > +TEST_SAME_NAMES="same RDMA device name can exist in two net namespaces" > +TEST_MOVE_CONFLICT="move without rename fails on destination name conflict" > +TEST_MOVE_RENAME="move then rename succeeds" > +TEST_COMBINED_MOVE_RENAME="move with requested destination name succeeds" > +TEST_SAME_NETNS_DUP_RENAME="same-netns rename rejects duplicate name" > +TEST_TEARDOWN_RETURN="netns delete returns device to init_net and renames on conflict" > + > +ksft_skip() > +{ > + ktap_skip_all "$*" > + exit "$KSFT_SKIP" > +} > + > +fail() > +{ > + ktap_exit_fail_msg "$*" > +} > + > +need_cmd() > +{ > + command -v "$1" >/dev/null 2>&1 || ksft_skip "missing command: $1" > +} > + > +rdma_ns() > +{ > + local ns=$1 > + > + shift > + ip netns exec "$ns" rdma "$@" > +} > + > +rdma_dev_exists() > +{ > + local ns=$1 > + local dev=$2 > + > + if [ -n "$ns" ]; then > + rdma_ns "$ns" dev show "$dev" >/dev/null 2>&1 > + else > + rdma dev show "$dev" >/dev/null 2>&1 > + fi > +} > + > +add_dummy() > +{ > + local netdev=$1 > + > + ip link add "$netdev" type dummy || return 1 > + ip link set "$netdev" up || return 1 > +} > + > +add_rxe() > +{ > + local dev=$1 > + local netdev=$2 > + > + rdma link add "$dev" type rxe netdev "$netdev" > +} > + > +rdma_dev_on_netdev() > +{ > + local netdev=$1 > + > + rdma link show 2>/dev/null | awk -v want="$netdev" ' > + { > + for (i = 1; i < NF; i++) > + if ($i == "netdev" && $(i + 1) == want) { > + dev = $2 > + sub(/\/.*/, "", dev) > + print dev > + exit > + } > + }' > +} > + > +wait_rdma_dev_on_netdev() > +{ > + local netdev=$1 > + local dev > + local i > + > + for i in $(seq 1 50); do > + dev=$(rdma_dev_on_netdev "$netdev") > + if [ -n "$dev" ]; then > + echo "$dev" > + return 0 > + fi > + sleep 0.1 > + done > + > + return 1 > +} > + > +setup_devs() > +{ > + cleanup_devs > + > + add_dummy "$DUMMY_A" || return 1 > + add_dummy "$DUMMY_B" || return 1 > + > + add_rxe "$RXE_A" "$DUMMY_A" || return 1 > + add_rxe "$RXE_B" "$DUMMY_B" || return 1 > +} > + > +cleanup_devs() > +{ > + ip link del "$DUMMY_A" 2>/dev/null > + ip link del "$DUMMY_B" 2>/dev/null > +} > + > +setup() > +{ > + OLD_MODE=$(rdma system show 2>/dev/null | > + sed -n 's/.*netns \([^ ]*\).*/\1/p') > + [ -n "$OLD_MODE" ] || ksft_skip "failed to read RDMA netns mode" > + > + rdma system set netns exclusive >/dev/null 2>&1 || > + ksft_skip "rdma netns exclusive mode is not supported" > + MODE_CHANGED=1 > + > + ip netns add "$NS1" || return 1 > + ip netns add "$NS2" || return 1 > +} > + > +cleanup() > +{ > + cleanup_devs > + > + ip netns del "$NS1" 2>/dev/null > + ip netns del "$NS2" 2>/dev/null > + > + if [ "$MODE_CHANGED" -eq 1 ]; then > + rdma system set netns "$OLD_MODE" 2>/dev/null > + fi > + > + for m in "${MODS[@]}"; do > + modprobe -r "$m" 2>/dev/null > + done > +} > + > +rdma_supports_combined_move_rename() > +{ > + rdma dev help 2>&1 | grep -Eq 'netns .*name|name .*netns' > +} > + > +[ "$(id -u)" -eq 0 ] || ksft_skip "must be run as root" > +need_cmd ip > +need_cmd rdma > +need_cmd modprobe > + > +trap cleanup EXIT > + > +for m in "${MODS[@]}"; do > + modinfo "$m" >/dev/null 2>&1 || ksft_skip "module $m not found" > + modprobe "$m" || fail "failed to load $m" > +done > + > +setup || fail "failed to create net namespaces" > + > +ktap_print_header > +ktap_set_plan 7 > + > +if setup_devs && > + rdma dev set "$RXE_A" netns "$NS1" && > + rdma_ns "$NS1" dev set "$RXE_A" name "$RXE_SAME" && > + rdma dev set "$RXE_B" netns "$NS2" && > + rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME" && > + rdma_dev_exists "$NS1" "$RXE_SAME" && > + rdma_dev_exists "$NS2" "$RXE_SAME"; then > + ktap_test_pass "$TEST_SAME_NAMES" > +else > + ktap_test_fail "$TEST_SAME_NAMES" > +fi > +cleanup_devs > + > +if ! setup_devs || > + ! rdma dev set "$RXE_A" netns "$NS1" || > + ! rdma_ns "$NS1" dev set "$RXE_A" name "$RXE_SAME" || > + ! rdma dev set "$RXE_B" netns "$NS2" || > + ! rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME"; then > + ktap_test_fail "$TEST_MOVE_CONFLICT" > +elif rdma_ns "$NS1" dev set "$RXE_SAME" netns "$NS2" >/dev/null 2>&1; then > + ktap_test_fail "$TEST_MOVE_CONFLICT" > +elif rdma_dev_exists "$NS1" "$RXE_SAME" && > + rdma_dev_exists "$NS2" "$RXE_SAME"; then > + ktap_test_pass "$TEST_MOVE_CONFLICT" > +else > + ktap_test_fail "$TEST_MOVE_CONFLICT" > +fi > +cleanup_devs > + > +if ! setup_devs; then > + ktap_test_fail "$TEST_MOVE_RENAME" > +elif rdma dev set "$RXE_A" netns "$NS2" && > + rdma_ns "$NS2" dev set "$RXE_A" name "$RXE_NEW"; then > + if rdma_dev_exists "$NS2" "$RXE_NEW" && > + ! rdma_dev_exists "" "$RXE_A"; then > + ktap_test_pass "$TEST_MOVE_RENAME" > + else > + ktap_test_fail "$TEST_MOVE_RENAME" > + fi > +else > + ktap_test_fail "$TEST_MOVE_RENAME" > +fi > +cleanup_devs > + > +if ! rdma_supports_combined_move_rename; then > + ktap_test_skip "$TEST_COMBINED_MOVE_RENAME" > +elif ! setup_devs; then > + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME" > +elif rdma dev set "$RXE_A" netns "$NS2" name "$RXE_NEW"; then > + if rdma_dev_exists "$NS2" "$RXE_NEW" && > + ! rdma_dev_exists "" "$RXE_A"; then > + ktap_test_pass "$TEST_COMBINED_MOVE_RENAME" > + else > + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME" > + fi > +else > + ktap_test_fail "$TEST_COMBINED_MOVE_RENAME" > +fi > +cleanup_devs > + > +if ! setup_devs; then > + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME" > +elif rdma dev set "$RXE_A" name "$RXE_SAME" && > + rdma dev set "$RXE_B" name "$RXE_NEW"; then > + if rdma dev set "$RXE_A" name "$RXE_NEW" >/dev/null 2>&1; then > + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME" > + elif rdma_dev_exists "" "$RXE_SAME" && > + rdma_dev_exists "" "$RXE_NEW"; then > + ktap_test_pass "$TEST_SAME_NETNS_DUP_RENAME" > + else > + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME" > + fi > +else > + ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME" > +fi > +cleanup_devs > + > +if ! setup_devs; then > + ktap_test_fail "$TEST_TEARDOWN_RETURN" > +elif ! rdma dev set "$RXE_A" name "$RXE_SAME" || > + ! rdma dev set "$RXE_B" netns "$NS2" || > + ! rdma_ns "$NS2" dev set "$RXE_B" name "$RXE_SAME" || > + ! rdma_dev_exists "$NS2" "$RXE_SAME"; then > + ktap_test_fail "$TEST_TEARDOWN_RETURN" > +else > + ip netns del "$NS2" > + returned=$(wait_rdma_dev_on_netdev "$DUMMY_B") > + ktap_print_msg "device returned to init_net as '${returned:-}'" > + if rdma_dev_exists "" "$RXE_SAME" && > + [ -n "$returned" ] && > + [ "$returned" != "$RXE_SAME" ] && > + [ "${returned#ibdev}" != "$returned" ]; then > + ktap_test_pass "$TEST_TEARDOWN_RETURN" > + else > + ktap_test_fail "$TEST_TEARDOWN_RETURN" > + fi > +fi > +cleanup_devs > + > +ktap_finished -- Best Regards, Yanjun.Zhu