From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:48708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728324AbfIMHek (ORCPT ); Fri, 13 Sep 2019 03:34:40 -0400 Subject: Re: [PATCH] KVM: s390: Do not leak kernel stack data in the KVM_S390_INTERRUPT ioctl References: <20190912090050.20295-1-thuth@redhat.com> <6905df78-95f0-3d6d-aaae-910cd2d7a232@redhat.com> <253e67f6-0a41-13e8-4ca2-c651d5fcdb69@redhat.com> <239c8d0f-40fb-264a-bc10-445931a3cd9a@redhat.com> <20190913092030.373a9254.cohuck@redhat.com> From: Thomas Huth Message-ID: Date: Fri, 13 Sep 2019 09:34:34 +0200 MIME-Version: 1.0 In-Reply-To: <20190913092030.373a9254.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Cornelia Huck Cc: Christian Borntraeger , David Hildenbrand , Janosch Frank , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org On 13/09/2019 09.20, Cornelia Huck wrote: > On Thu, 12 Sep 2019 13:23:38 +0200 > Thomas Huth wrote: > >> Hmm, we already talked about deprecating support for pre-3.15 kernel >> stuff in the past (see >> https://wiki.qemu.org/ChangeLog/2.12#Future_incompatible_changes for >> example), > > Btw: did we ever do that? I don't quite recall what code we were > talking about... We never really did - but we also never fixed the issue: If you run the current QEMU on a kernel before 3.15, it refuses to work due to the missing in-kernel FLIC device: Initialization of device s390-flic-kvm failed: KVM is missing capability KVM_CAP_DEVICE_CTR Since nobody really complained so far that running QEMU with KVM is still required on a kernel < 3.15, I think we could make this also "official" now and improve the error message a little bit, pointing the user to a kernel >= 3.15. Thomas