Re: [kvm-unit-tests PATCH 1/2] s390x: Move to GPL 2 and SPDX license identifiers

Janosch Frank
2020-12-09T09:50:00Z

[-- Attachment #1.1.1: Type: text/plain, Size: 1259 bytes --]

On 12/9/20 10:19 AM, David Hildenbrand wrote:
> On 09.12.20 10:12, David Hildenbrand wrote:
>> On 08.12.20 16:09, Janosch Frank wrote:
>>> In the past we had some issues when developers wanted to use code
>>> snippets or constants from the kernel in a test or in the library. To
>>> remedy that the s390x maintainers decided to move all files to GPL
>>> 2 (if possible).
>>>
>>> At the same time let's move to SPDX identifiers as they are much nicer
>>> to read.
>>>
>>
>> If I am not wrong, your patch only replaces existing license text by
>> SPDX identifiers. So I find this commit message rather confusing. The
>> "at the same time" is actually the only thing that is being done - or am
>> I missing something important?
>>
>> I wonder of we can just convert everything to GPL-2.0-or-later, the list
>> of people that contributed to most files is rather limited, so getting
>> most acks should be easy.
>>
>
> Aehm, I missed the "Library" part :D

If you look closely I remove the LGPL license blob and add a GPL2 SPDX
identifier. One more reason to move to SPDX, the license blobs are hard
to read as they are very similar until you come to the (L)GPL part.

>
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks

[-- Attachment #1.1.2: OpenPGP_0xE354E6B8E238B9F8.asc --]
[-- Type: application/pgp-keys, Size: 7995 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]