From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CE0C77B73 for ; Wed, 31 May 2023 12:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236070AbjEaM4o (ORCPT ); Wed, 31 May 2023 08:56:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236093AbjEaM4g (ORCPT ); Wed, 31 May 2023 08:56:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EEB01A8 for ; Wed, 31 May 2023 05:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685537696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ygumGN7X55a4YT6OXk5KW6eBqJUAFJLGuz5I8swlOKo=; b=CnV8glpbU74MnqEso3qjjBbkMaTwLA4SjEFKmwA9lEoW2ozY5y0DCv5NuueXucpx790KvK Ag4p3z2mI3kti741p9/EbgPmT/s5oegHqjdI5MwjjHQCyPXZtnDMevaUBkR6TXijh3cCwN uzD6AsO5JPmOVMTEeTYDbgIRGVRS6Ak= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-HiT7DJrCO72xnBXJSEDs1w-1; Wed, 31 May 2023 08:54:54 -0400 X-MC-Unique: HiT7DJrCO72xnBXJSEDs1w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f603fed174so35661725e9.2 for ; Wed, 31 May 2023 05:54:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685537693; x=1688129693; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ygumGN7X55a4YT6OXk5KW6eBqJUAFJLGuz5I8swlOKo=; b=IVQeRewMuLXNZVNTPcSYBLIm+TcL07kr+PObAoOfSkf1krlwdaxmX82QxPKnJByHVQ rmwzLwvc0u4fx6Cd5HtlfbV67pjtuNy1pRlQbxhkHo/w0pMGDjowVvjRZmAU3gzWCGKY J0gIbjwPhLjTFKPvF1HdqM9mhCaRyrzNumH8WEnYKPGhdtQ5gF2+rwbA9Vcls0tHgcoQ u1pyeUjW9L6EEilQATgi/SOP5s46zd2i+pw13ld5XfpdeRf/P+CtqXQLAihvBVV5xF1H xEY03waEBEx6dn6Fl1UNoC2ymbaS4LOGlTWLSrPg8LrGtMdKpKxs+Yz4z2/v1CIhDN1a 8Q8A== X-Gm-Message-State: AC+VfDyFceM3bWFQxOlUtuzQmPHyJd3RaC9cgSDjAswLtqdLjqUnpGW8 EEjJ5Gtxq3uJC0YH0EdGwZAmQS9uqUjlKieyTK95iyRx8eKCMYD62fLZvF861C9CkeUbmmLNpvJ XL/3772f9AV2LEVFXAnxK1A== X-Received: by 2002:a7b:c443:0:b0:3f6:d2c:13f2 with SMTP id l3-20020a7bc443000000b003f60d2c13f2mr3633055wmi.41.1685537693632; Wed, 31 May 2023 05:54:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ53y3nHkEIs9gDQuKrVRGMfK7+9RTjlLyqmreSuJWMiVwoz/K5Dscg26XcfN5rtozVUWxREew== X-Received: by 2002:a7b:c443:0:b0:3f6:d2c:13f2 with SMTP id l3-20020a7bc443000000b003f60d2c13f2mr3633034wmi.41.1685537693348; Wed, 31 May 2023 05:54:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:eb4a:c9d8:c8bb:c0b0? ([2a01:e0a:280:24f0:eb4a:c9d8:c8bb:c0b0]) by smtp.gmail.com with ESMTPSA id n26-20020a7bcbda000000b003f60482024fsm20807853wmi.30.2023.05.31.05.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 05:54:52 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 14:54:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/3] vfio: ap: realize the VFIO_DEVICE_GET_IRQ_INFO ioctl Content-Language: en-US To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jjherne@linux.ibm.com, pasic@linux.ibm.com, farman@linux.ibm.com, mjrosato@linux.ibm.com, alex.williamson@redhat.com, borntraeger@linux.ibm.com References: <20230530223538.279198-1-akrowiak@linux.ibm.com> <20230530223538.279198-2-akrowiak@linux.ibm.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230530223538.279198-2-akrowiak@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 5/31/23 00:35, Tony Krowiak wrote: > Realize the VFIO_DEVICE_GET_IRQ_INFO ioctl to retrieve the information for > the VFIO device request IRQ. > > Signed-off-by: Tony Krowiak Reviewed-by: Cédric Le Goater Thanks, C. > --- > drivers/s390/crypto/vfio_ap_ops.c | 30 +++++++++++++++++++++++++++++- > include/uapi/linux/vfio.h | 9 +++++++++ > 2 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index cfbcb864ab63..35cd90eee937 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -1750,7 +1750,32 @@ static int vfio_ap_mdev_get_device_info(unsigned long arg) > > info.flags = VFIO_DEVICE_FLAGS_AP | VFIO_DEVICE_FLAGS_RESET; > info.num_regions = 0; > - info.num_irqs = 0; > + info.num_irqs = VFIO_AP_NUM_IRQS; > + > + return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0; > +} > + > +static ssize_t vfio_ap_get_irq_info(unsigned long arg) > +{ > + unsigned long minsz; > + struct vfio_irq_info info; > + > + minsz = offsetofend(struct vfio_irq_info, count); > + > + if (copy_from_user(&info, (void __user *)arg, minsz)) > + return -EFAULT; > + > + if (info.argsz < minsz || info.index >= VFIO_AP_NUM_IRQS) > + return -EINVAL; > + > + switch (info.index) { > + case VFIO_AP_REQ_IRQ_INDEX: > + info.count = 1; > + info.flags = VFIO_IRQ_INFO_EVENTFD; > + break; > + default: > + return -EINVAL; > + } > > return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0; > } > @@ -1770,6 +1795,9 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev, > case VFIO_DEVICE_RESET: > ret = vfio_ap_mdev_reset_queues(&matrix_mdev->qtable); > break; > + case VFIO_DEVICE_GET_IRQ_INFO: > + ret = vfio_ap_get_irq_info(arg); > + break; > default: > ret = -EOPNOTSUPP; > break; > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 0552e8dcf0cb..b71276bd7f91 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -646,6 +646,15 @@ enum { > VFIO_CCW_NUM_IRQS > }; > > +/* > + * The vfio-ap bus driver makes use of the following IRQ index mapping. > + * Unimplemented IRQ types return a count of zero. > + */ > +enum { > + VFIO_AP_REQ_IRQ_INDEX, > + VFIO_AP_NUM_IRQS > +}; > + > /** > * VFIO_DEVICE_GET_PCI_HOT_RESET_INFO - _IOWR(VFIO_TYPE, VFIO_BASE + 12, > * struct vfio_pci_hot_reset_info)