Re: [PATCH 5/6] net: hns3: Remove io_stop_wc() calls after __iowrite64_copy()

Jijie Shao
2024-02-22T00:57:24Z

Reviewed-by: Jijie Shao<shaojijie@huawei.com>

on 2024/2/21 9:17, Jason Gunthorpe wrote:
> Now that the ARM64 arch implementation does the DGH as part of
> __iowrite64_copy() there is no reason to open code this in drivers.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index f1695c889d3a07..ff556c2b5bacb4 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2068,8 +2068,6 @@ static void hns3_tx_push_bd(struct hns3_enet_ring *ring, int num)
> __iowrite64_copy(ring->tqp->mem_base, desc,
> (sizeof(struct hns3_desc) * HNS3_MAX_PUSH_BD_NUM) /
> HNS3_BYTES_PER_64BIT);
> -
> - io_stop_wc();
> }
>
> static void hns3_tx_mem_doorbell(struct hns3_enet_ring *ring)
> @@ -2088,8 +2086,6 @@ static void hns3_tx_mem_doorbell(struct hns3_enet_ring *ring)
> u64_stats_update_begin(&ring->syncp);
> ring->stats.tx_mem_doorbell += ring->pending_buf;
> u64_stats_update_end(&ring->syncp);
> -
> - io_stop_wc();
> }
>
> static void hns3_tx_doorbell(struct hns3_enet_ring *ring, int num,