Re: [kvm-unit-tests PATCH 5/6] s390x: Prepare for external calls

Janosch Frank
2019-09-02T14:17:31Z

[-- Attachment #1.1: Type: text/plain, Size: 1298 bytes --]

On 9/2/19 3:58 PM, Thomas Huth wrote:
> On 29/08/2019 14.14, Janosch Frank wrote:
>> With SMP we also get new external interrupts like external call and
>> emergency call. Let's make them known.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> lib/s390x/asm/arch_def.h | 5 +++++
>> lib/s390x/asm/interrupt.h | 3 +++
>> lib/s390x/interrupt.c | 24 ++++++++++++++++++++----
>> 3 files changed, 28 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
>> index d5a7f51..5ece2ce 100644
>> --- a/lib/s390x/asm/arch_def.h
>> +++ b/lib/s390x/asm/arch_def.h
>> @@ -19,6 +19,11 @@ struct psw {
>> #define PSW_MASK_DAT 0x0400000000000000UL
>> #define PSW_MASK_PSTATE 0x0001000000000000UL
>>
>> +#define CR0_EXTM_SCLP 0X0000000000000200UL
>> +#define CR0_EXTM_EXTC 0X0000000000004000UL
>> +#define CR0_EXTM_EMGC 0X0000000000008000UL
>> +#define CR0_EXTM_MASK 0X000000000001DD40UL
>
> I think I need more coffee... but if I still count right, the EXTC, EMGC
> and some of the mask bits seem to be off-by-one ? Could that be? Please
> double-check.
>
> Thomas

They are definitely wrong, but as they are not used anyway it doesn't
make a difference in the test that follows -_-

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]