Re: [PATCH net-next v6 02/11] net/smc: introduce loopback-ism for SMC intra-OS shortcut

Gerd Bayer
2024-04-17T10:20:20Z

On Sun, 2024-04-14 at 12:02 +0800, Wen Gu wrote:
> This introduces a kind of Emulated-ISM device named loopback-ism for
> SMCv2.1. The loopback-ism device is currently exclusive for SMC
> usage, and aims to provide an SMC shortcut for sockets within the
> same kernel, leading to improved intra-OS traffic performance.
> Configuration of this feature is managed through the config SMC_LO.
>
> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
> ---
>  net/smc/Kconfig        |  13 ++++
>  net/smc/Makefile       |   1 +
>  net/smc/af_smc.c       |  12 +++-
>  net/smc/smc_loopback.c | 156
> +++++++++++++++++++++++++++++++++++++++++
>  net/smc/smc_loopback.h |  43 ++++++++++++
>  5 files changed, 224 insertions(+), 1 deletion(-)
>  create mode 100644 net/smc/smc_loopback.c
>  create mode 100644 net/smc/smc_loopback.h
>

Thanks Wen Gu,

this looks good to me now. A W=1 compile-test of the whole series with
SMC_LO undefined showed that there were no additional unresolved
symbols introduced.

Feel free to add my
Reviewed-by: Gerd Bayer <gbayer@linux.ibm.com>