From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31607 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232401AbhBIPQX (ORCPT ); Tue, 9 Feb 2021 10:16:23 -0500 Subject: Re: [kvm-unit-tests PATCH 1/8] s390x: Fix fpc store address in RESTORE_REGS_STACK References: <20210209134925.22248-1-frankja@linux.ibm.com> <20210209134925.22248-2-frankja@linux.ibm.com> From: Thomas Huth Message-ID: Date: Tue, 9 Feb 2021 16:14:46 +0100 MIME-Version: 1.0 In-Reply-To: <20210209134925.22248-2-frankja@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Janosch Frank , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, david@redhat.com, pmorel@linux.ibm.com, imbrenda@linux.ibm.com On 09/02/2021 14.49, Janosch Frank wrote: > The efpc stores in bits 32-63 of a register and we store a full 8 > bytes to have the stack 8 byte aligned. This means that the fpc is > stored at offset 4 but we load it from offset 0. Lets replace efpc > with stfpc and get rid of the stg to store at offset 0. > > Signed-off-by: Janosch Frank > Reviewed-by: Claudio Imbrenda > Reviewed-by: Pierre Morel > --- > s390x/macros.S | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/s390x/macros.S b/s390x/macros.S > index 37a6a63e..e51a557a 100644 > --- a/s390x/macros.S > +++ b/s390x/macros.S > @@ -54,8 +54,7 @@ > .endr > /* Save fpc, but keep stack aligned on 64bits */ > slgfi %r15, 8 > - efpc %r0 > - stg %r0, 0(%r15) > + stfpc 0(%r15) > .endm Reviewed-by: Thomas Huth