Re: [PATCH v1 1/6] s390/boot/uv.c: Use a constant for more-data rc

Claudio Imbrenda
2024-10-01T16:46:53Z

On Mon, 30 Sep 2024 15:19:04 +0200
Steffen Eiden <seiden@linux.ibm.com> wrote:

> Add a define for the UVC rc 0x0100 that indicates that a UV-call was
> successful but may serve more data if called with a larger buffer
> again.
>
> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> ---
> arch/s390/boot/uv.c | 4 ++--
> arch/s390/include/asm/uv.h | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/boot/uv.c b/arch/s390/boot/uv.c
> index 318e6ba95bfd..2a71e759dc42 100644
> --- a/arch/s390/boot/uv.c
> +++ b/arch/s390/boot/uv.c
> @@ -22,8 +22,8 @@ void uv_query_info(void)
> if (!test_facility(158))
> return;
>
> - /* rc==0x100 means that there is additional data we do not process */
> - if (uv_call(0, (uint64_t)&uvcb) && uvcb.header.rc != 0x100)
> + /* Ignore that there might be more data we do not process */
> + if (uv_call(0, (uint64_t)&uvcb) && uvcb.header.rc != UVC_RC_MORE_DATA)
> return;
>
> if (IS_ENABLED(CONFIG_KVM)) {
> diff --git a/arch/s390/include/asm/uv.h b/arch/s390/include/asm/uv.h
> index 153d93468b77..94ff58336e8e 100644
> --- a/arch/s390/include/asm/uv.h
> +++ b/arch/s390/include/asm/uv.h
> @@ -28,6 +28,7 @@
> #define UVC_RC_INV_STATE 0x0003
> #define UVC_RC_INV_LEN 0x0005
> #define UVC_RC_NO_RESUME 0x0007
> +#define UVC_RC_MORE_DATA 0x0100
> #define UVC_RC_NEED_DESTROY 0x8000
>
> #define UVC_CMD_QUI 0x0001