From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from iad-out-001.esa.us-east-1.outbound.mail-perimeter.amazon.com (iad-out-001.esa.us-east-1.outbound.mail-perimeter.amazon.com [107.22.191.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D97F3E3141; Fri, 10 Apr 2026 15:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=107.22.191.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834752; cv=none; b=Yoot4fEc+10s0BDChZHJmNkTGUXNZhL3OW3jZvaDx60YUh9Mqgb3F+pQBcEhMFPDpa1VyNKsKQqGPZaDXJ1QMyU2tvpuvaZZoJqwwxp+sx102CDDMctJ2SmZOfUHA5X0ZaD8L8XUtwrERRAAdhv0loWz4p9rVrKhqD6UmhJf2iM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775834752; c=relaxed/simple; bh=6NArw1uwvitOg/jIfrfJACQU4BNxnZYs12Ybl8tGKxA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IQxuBZyy8A1UZjoeQTPqvn4uU1TS9hAC2qzoZ7A0HP/WvEIYYmFAySRSm0tFKQBqzyqxoi87bm4X9vSNnVeAMpxDk520mTalbeQh52f5mKG6aJsAQHyggP+7hsttSSkSMt7GmENcXPdRngxoKQiseEBEZTDF0LWzs+JCo6z210w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=aeaaS43f; arc=none smtp.client-ip=107.22.191.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="aeaaS43f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1775834751; x=1807370751; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=ol7pcngOj6CrfOGKJ1Q8+hUmGyttlI2sRZ1Q0xls5wA=; b=aeaaS43frhG1iXYIq5IZawWJ0YI67ZOpW8epibK0WdnnoaKAOewATend tCgfhjnR549oiTJd/uGYIqgXlj6PQ8Nq05MsJaKrOuICeFIqXDmtlGomD CupokE95B2WmTbNqB40FwXtXb33foGW1+uw9OuaIP+8O1tMFM4mtSra4P 60x5eqmGQtZLRmOYUNTnrNj+Wc75+WMax+TSLVd+ALvHJMFpuXQ/uxgPU 6TXywDa7Hl/IlhwIByi+Z1sJ/IV9wsPSZHLk/ZQX3XHWLaNOzlhBXgXdu sCWuAV6JCzJU4iNlmecoTTnpBCzmqXUuGns6KtGlGlDAKfqd1rKsngINf w==; X-CSE-ConnectionGUID: C6NGMfEdR0yLPJiR2UsJqg== X-CSE-MsgGUID: FNMxIsp6SHKbEpn1aSfTPQ== X-IronPort-AV: E=Sophos;i="6.23,171,1770595200"; d="scan'208";a="15526458" Received: from ip-10-4-3-150.ec2.internal (HELO smtpout.naws.us-east-1.prod.farcaster.email.amazon.dev) ([10.4.3.150]) by internal-iad-out-001.esa.us-east-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 15:25:49 +0000 Received: from EX19MTAUEC001.ant.amazon.com [52.94.133.142:11264] by smtpin.naws.us-east-1.prod.farcaster.email.amazon.dev [10.0.59.187:2525] with esmtp (Farcaster) id 0e62ab68-b87c-485a-aa3c-53498707ba15; Fri, 10 Apr 2026 15:25:49 +0000 (UTC) X-Farcaster-Flow-ID: 0e62ab68-b87c-485a-aa3c-53498707ba15 Received: from EX19D027UEC003.ant.amazon.com (10.252.137.250) by EX19MTAUEC001.ant.amazon.com (10.252.135.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:25:48 +0000 Received: from [192.168.12.97] (10.106.82.30) by EX19D027UEC003.ant.amazon.com (10.252.137.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 10 Apr 2026 15:25:35 +0000 Message-ID: Date: Fri, 10 Apr 2026 16:25:33 +0100 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v11 02/16] set_memory: add folio_{zap, restore}_direct_map helpers To: "David Hildenbrand (Arm)" , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-pm@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "vbabka@kernel.org" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "skhan@linuxfoundation.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "yosry@kernel.org" , "ajones@ventanamicro.com" , "maobibo@loongson.cn" , "tabba@google.com" , "prsampat@amd.com" , "wu.fei9@sanechips.com.cn" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" References: <20260317141031.514-1-kalyazin@amazon.com> <20260317141031.514-3-kalyazin@amazon.com> <54f9b5a7-b8a9-486a-9c12-a910f5287947@kernel.org> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJp2NfjBQkGQlIzAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPPNDAEAvsw8vEWj8ArWQ1QJNufjrvobU/cE8MLKdBxbSE8CyZQA/0BldKxNAtAwG4qw wCLxsZ5vBL3Zkh/PdvtFCj/VGscGzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmnY1+MFCQZCUjMCGwwACgkQr5LKIKmaZPPQKgD/f3FtERbJ+LYHLSG/ZbLNAOLngUlQ qo5VfIyJOzeLzC0BAP2PIUFIHo7vmia/PXEmT+ve4c5rx+EkH/Dx1GRpjWoI In-Reply-To: <54f9b5a7-b8a9-486a-9c12-a910f5287947@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D007EUA004.ant.amazon.com (10.252.50.76) To EX19D027UEC003.ant.amazon.com (10.252.137.250) On 23/03/2026 17:51, David Hildenbrand (Arm) wrote: > On 3/17/26 15:10, Kalyazin, Nikita wrote: >> From: Nikita Kalyazin >> >> Let's provide folio_{zap,restore}_direct_map helpers as preparation for >> supporting removal of the direct map for guest_memfd folios. >> In folio_zap_direct_map(), flush TLB to make sure the data is not >> accessible. >> >> The new helpers need to be accessible to KVM on architectures that >> support guest_memfd (x86 and arm64). >> >> Direct map removal gives guest_memfd the same protection that >> memfd_secret does, such as hardening against Spectre-like attacks >> through in-kernel gadgets. > > Maybe mention that there might be a double TLB flush on some > architectures, but that that is something to figure out later. Same > behavior in secretmem code where this will be used next. Added, thanks. > >> >> Signed-off-by: Nikita Kalyazin >> --- >> include/linux/set_memory.h | 13 ++++++++++++ >> mm/memory.c | 42 ++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 55 insertions(+) >> >> diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h >> index 1a2563f525fc..24caea2931f9 100644 >> --- a/include/linux/set_memory.h >> +++ b/include/linux/set_memory.h >> @@ -41,6 +41,15 @@ static inline int set_direct_map_valid_noflush(const void *addr, >> return 0; >> } >> >> +static inline int folio_zap_direct_map(struct folio *folio) >> +{ >> + return 0; > > Should we return -ENOSYS here or similar? I'm not very certain about it because set_direct_map_* return 0 in this case. Do we want them to behave differently? > >> +} >> + >> +static inline void folio_restore_direct_map(struct folio *folio) >> +{ >> +} >> + >> static inline bool kernel_page_present(struct page *page) >> { >> return true; >> @@ -57,6 +66,10 @@ static inline bool can_set_direct_map(void) >> } >> #define can_set_direct_map can_set_direct_map >> #endif >> + >> +int folio_zap_direct_map(struct folio *folio); >> +void folio_restore_direct_map(struct folio *folio); >> + >> #endif /* CONFIG_ARCH_HAS_SET_DIRECT_MAP */ >> >> #ifdef CONFIG_X86_64 >> diff --git a/mm/memory.c b/mm/memory.c >> index 07778814b4a8..cab6bb237fc0 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -78,6 +78,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> @@ -7478,3 +7479,44 @@ void vma_pgtable_walk_end(struct vm_area_struct *vma) >> if (is_vm_hugetlb_page(vma)) >> hugetlb_vma_unlock_read(vma); >> } >> + >> +#ifdef CONFIG_ARCH_HAS_SET_DIRECT_MAP >> +/** >> + * folio_zap_direct_map - remove a folio from the kernel direct map >> + * @folio: folio to remove from the direct map >> + * >> + * Removes the folio from the kernel direct map and flushes the TLB. This may >> + * require splitting huge pages in the direct map, which can fail due to memory >> + * allocation. > > Best to mention > > "So far, only order-0 folios are supported." and then ... > >> + * >> + * Return: 0 on success, or a negative error code on failure. >> + */ >> +int folio_zap_direct_map(struct folio *folio) >> +{ >> + const void *addr = folio_address(folio); >> + int ret; >> + > > if (folio_test_large(folio)) > return -EINVAL; Added, thanks. > > > With that, > > Acked-by: David Hildenbrand (Arm) Thank you. > > -- > Cheers, > > David