From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727355AbgJaO64 (ORCPT ); Sat, 31 Oct 2020 10:58:56 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77C06C061A48 for ; Sat, 31 Oct 2020 07:58:55 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id 13so7539811pfy.4 for ; Sat, 31 Oct 2020 07:58:55 -0700 (PDT) Subject: Re: [PATCH 02/11] mtip32xx: return -ENOTTY for all unhanled ioctls References: <20201031085810.450489-1-hch@lst.de> <20201031085810.450489-3-hch@lst.de> From: Jens Axboe Message-ID: Date: Sat, 31 Oct 2020 08:58:52 -0600 MIME-Version: 1.0 In-Reply-To: <20201031085810.450489-3-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Christoph Hellwig Cc: Ilya Dryomov , Song Liu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Stefan Haberland , Jan Hoeppner , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org On 10/31/20 2:58 AM, Christoph Hellwig wrote: > -ENOTTY is the convention for "driver does not support this ioctl". > Use it properly in mtip32xx instead of the bogys -EINVAL. While that's certainly true, there is a risk in making a change like this years after the fact. Not that I expect there are any mtip32xx users left at this point, but... -- Jens Axboe