From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22948 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726193AbgDXKKC (ORCPT ); Fri, 24 Apr 2020 06:10:02 -0400 Subject: Re: [PATCH v2 07/10] s390x: smp: Use full PSW to bringup new cpu References: <20200423091013.11587-1-frankja@linux.ibm.com> <20200423091013.11587-8-frankja@linux.ibm.com> From: David Hildenbrand Message-ID: Date: Fri, 24 Apr 2020 12:09:50 +0200 MIME-Version: 1.0 In-Reply-To: <20200423091013.11587-8-frankja@linux.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Janosch Frank , kvm@vger.kernel.org Cc: thuth@redhat.com, linux-s390@vger.kernel.org, borntraeger@de.ibm.com, cohuck@redhat.com On 23.04.20 11:10, Janosch Frank wrote: > Up to now we ignored the psw mask and only used the psw address when > bringing up a new cpu. For DAT we need to also load the mask, so let's > do that. > > Signed-off-by: Janosch Frank > Reviewed-by: Cornelia Huck > --- > lib/s390x/smp.c | 2 ++ > s390x/cstart64.S | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c > index 3f86243..6ef0335 100644 > --- a/lib/s390x/smp.c > +++ b/lib/s390x/smp.c > @@ -202,6 +202,8 @@ int smp_cpu_setup(uint16_t addr, struct psw psw) > cpu->stack = (uint64_t *)alloc_pages(2); > > /* Start without DAT and any other mask bits. */ > + cpu->lowcore->sw_int_psw.mask = psw.mask; > + cpu->lowcore->sw_int_psw.addr = psw.addr; > cpu->lowcore->sw_int_grs[14] = psw.addr; Do we still have to set sw_int_grs[14] ? -- Thanks, David / dhildenb