From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3824C433EF for ; Thu, 21 Apr 2022 07:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385719AbiDUH1T (ORCPT ); Thu, 21 Apr 2022 03:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385716AbiDUH1T (ORCPT ); Thu, 21 Apr 2022 03:27:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2433B183A1 for ; Thu, 21 Apr 2022 00:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650525867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ueojm38snUDgcNkd8GnzNsJGz3O6fhwaTuAkVszcmuo=; b=NFX49FIfuJj38zcz16yV4P/6aSjoTusGBllY1/OEwfb0RwP6Qy82hMDY4GJt1RhlIRlng4 HKyWz9W23Agso2rWzeewUhHR6zJsjPew0fyyvGsYNREMpWmbH/ip26keS6BZPR1Lk+mMZh LATtvf2rgZq1sEaQV54puq9cg6VSJjs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-XudUrJcANnK11a-YsHWfHw-1; Thu, 21 Apr 2022 03:24:26 -0400 X-MC-Unique: XudUrJcANnK11a-YsHWfHw-1 Received: by mail-wm1-f69.google.com with SMTP id r9-20020a1c4409000000b0038ff033b654so2012703wma.0 for ; Thu, 21 Apr 2022 00:24:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=Ueojm38snUDgcNkd8GnzNsJGz3O6fhwaTuAkVszcmuo=; b=hFRdh8tCuk/1mgK0lhiVj03CPSN31OABQVFsja/cUjbVWMPDNtCMJOVeEwoXiq9pQv RR96O53ut2zugL5brhMt3FqGYPd20KyCO7IrkmfDxNjfN9jpwUSKla6sdXK9s0wGcZxm +6Fl8gsx0TCA8XETOdoSPN14p41jFQtWYUGWiPk2H4K+aF7EpSknEvLaod7ngCDdXV1S 8HiCLouR3Fjh8ReuHgdYcnBmzLW6CCiu5XeZRPk71JyswEOPL48UGLAUxr03vaREIt4X HqWJCqx3/DDLT0gsBr4akabqTraV8XnwZMHn9lUMoeLHsybADVg/yaaZYOhphgNqHKOh s6Rw== X-Gm-Message-State: AOAM531xmiAX67hJ+x9kxexVH6H5K91yFGrTm0dlrc56havWI7hvEtfJ HcrdO5iEXChsnfw6RDbi2XmTsFw5lw8ewqFKJpqqazbGupSY+RLKPT6tgH4FgYOV+KYkxlxz+gC T3Imr1s7rpgeCTYvSMdoWoQ== X-Received: by 2002:a05:600c:4f53:b0:392:e99:3002 with SMTP id m19-20020a05600c4f5300b003920e993002mr7271151wmq.35.1650525864749; Thu, 21 Apr 2022 00:24:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT3pnm5Sh+vV0Sy7hhyznn/LgwWMwSX+xjIVufjxa9zkFnFGy5AD9tPDmaVij6DMrjv3pJ9w== X-Received: by 2002:a05:600c:4f53:b0:392:e99:3002 with SMTP id m19-20020a05600c4f5300b003920e993002mr7271129wmq.35.1650525864513; Thu, 21 Apr 2022 00:24:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:de00:711b:76af:b335:9b70? (p200300cbc702de00711b76afb3359b70.dip0.t-ipconnect.de. [2003:cb:c702:de00:711b:76af:b335:9b70]) by smtp.gmail.com with ESMTPSA id t9-20020adfa2c9000000b002061561d4a7sm1601302wra.96.2022.04.21.00.24.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 00:24:21 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 09:24:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 3/4] KVM: s390: replace bitmap_copy with bitmap_{from,to}_arr64 where appropriate Content-Language: en-US To: Yury Norov , linux-kernel@vger.kernel.org, Alexander Gordeev , Andy Shevchenko , Christian Borntraeger , Claudio Imbrenda , Heiko Carstens , Janosch Frank , Rasmus Villemoes , Sven Schnelle , Vasily Gorbik , linux-s390@vger.kernel.org, kvm@vger.kernel.org References: <20220420222530.910125-1-yury.norov@gmail.com> <20220420222530.910125-4-yury.norov@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220420222530.910125-4-yury.norov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 21.04.22 00:25, Yury Norov wrote: > Copying bitmaps from/to 64-bit arrays with bitmap_copy is not safe > in general case. Use designated functions instead. > Just so I understand correctly: there is no BUG, it's just cleaner to do it that way, correct? IIUC, bitmap_to_arr64() translates to bitmap_copy_clear_tail() on s390x. As the passed length is always 1024 (KVM_S390_VM_CPU_FEAT_NR_BITS), we essentially end up with bitmap_copy() again. Looks cleaner to me Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb