Re: [PATCH v3 1/1] vfio-ccw: Prevent quiesce function going into an infinite loop

Eric Farman
2019-04-23T20:37:36Z

On 4/23/19 3:41 PM, Farhan Ali wrote:
>
>
> On 04/23/2019 01:42 PM, Halil Pasic wrote:

...snip...

>> TL;DR:
>>
>> I welcome  this batch (with an r-b) but I would like the commit message
>> and the comment changed so that the misleading 'flush all I/O in the
>> workqueue'.
>>
>> I think 'vfio-ccw: fix cio_cancel_halt_clear() usage' would reflect the
>> content of this patch better, because reasoning about the upper limit,
>> and what happens if this upper limit is hit is not what this patch is
>> about. It is about a client code bug that rendered iretry ineffective.
>>
>
> I politely disagree with the change in subject line. I think the current
> subject line describe what we are trying to prevent with this patch. But
> again if anyone else feels otherwise, I will go ahead and change :)

I think the entire patch is fine as-is.

Reviewed-by: Eric Farman <farman@linux.ibm.com>

>
> Thanks
> Farhan
>
>
>> Regards,
>> Halil
>>
>>