From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9009B48AE38; Thu, 3 Sep 2026 10:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788432357; cv=none; b=NIfG44UuNDFPUA6ShhA2FM4jdVoyjTChWroCb8uUhrr/n+GRiJAyLoFc1nKGeN3PIsbxFPsbNYMhJhAKwjCXIco8uj9NhiH6K9BCCeIDGkkQ4O2rcLLmRDJePC+vuIFYAfIqU3JYp0aTJGVjfrmIm3BAqK2YtRLv9kb3ftmx+uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788432357; c=relaxed/simple; bh=B2EGgiinFjR7PIuJDjwPP8zw52e7kf6hQY7DC+ox1r0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Oq3g8JWbpK306UAligVKarH+Kkf3OueQVEOqR/fsbGdvBbKA+zygjLbYS0Vnr+0c1YjqWePSdJmjaTcVEzslYKqm+QLieHQIWQO6q0XA1LrRkNqFY5TpxGGMQZ7axGmT/yituJJkv5Tf2kd/JmqoFm3e9hV5HAACk2JxEjiCnsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=mmq3evjb; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="mmq3evjb" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B2FD1596; Thu, 3 Sep 2026 03:45:51 -0700 (PDT) Received: from [10.164.19.53] (unknown [10.164.19.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B13C3F673; Thu, 3 Sep 2026 03:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1788432354; bh=B2EGgiinFjR7PIuJDjwPP8zw52e7kf6hQY7DC+ox1r0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mmq3evjbS8hafbKWyN6WfvB9UfVySk+qoHqsF1QzrHYtoeRp/5znyDeIxQ0XWmzpM HmppJc+wsmOrkjn5ugj5vuGdbtya+eR9c57C4aB5SNws+Twq1UmKFOoPZzxS2fmElr iaXr3Hj7l3p0cwNUfXzOQlwUrYPQgaUrPZbbaJFc= Message-ID: Date: Thu, 3 Sep 2026 16:15:42 +0530 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/6] mm/vmalloc: constify vm parameter of get_vm_area_page_order() To: "Mike Rapoport (Microsoft)" , Andrew Morton Cc: =?UTF-8?Q?Adrian_Barna=C5=9B?= , Albert Ou , Alexander Gordeev , Alexandre Ghiti , Andy Lutomirski , Borislav Petkov , Brendan Jackman , Catalin Marinas , Christian Borntraeger , Dave Hansen , David Hildenbrand , Gerald Schaefer , Heiko Carstens , Huacai Chen , Ingo Molnar , Len Brown , Palmer Dabbelt , Paul Walmsley , Pavel Machek , Peter Zijlstra , "H. Peter Anvin" , "Rafael J. Wysocki" , Ryan Roberts , Sven Schnelle , Thomas Gleixner , Uladzislau Rezki , Vasily Gorbik , WANG Xuerui , Will Deacon , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, loongarch@lists.linux.dev References: <20260903-execmem-set-vm-perms-v0-2-v3-0-949b64a9f755@kernel.org> <20260903-execmem-set-vm-perms-v0-2-v3-3-949b64a9f755@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20260903-execmem-set-vm-perms-v0-2-v3-3-949b64a9f755@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/09/26 2:58 pm, Mike Rapoport (Microsoft) wrote: > get_vm_area_page_order() and vm_area_page_order() do not need to modify > struct vm_struct passed to them. > > Constify the parameter. > > Reviewed-by: Uladzislau Rezki (Sony) > Signed-off-by: Mike Rapoport (Microsoft) > --- Reviewed-by: Dev Jain > mm/vmalloc.c | 4 ++-- > mm/vmalloc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 22aa554d123f5..5506b180f5c27 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3130,7 +3130,7 @@ EXPORT_SYMBOL(vm_map_ram); > > static struct vm_struct *vmlist __initdata; > > -static inline unsigned int vm_area_page_order(struct vm_struct *vm) > +static inline unsigned int vm_area_page_order(const struct vm_struct *vm) > { > #ifdef CONFIG_HAVE_ARCH_HUGE_VMALLOC > return vm->page_order; > @@ -3139,7 +3139,7 @@ static inline unsigned int vm_area_page_order(struct vm_struct *vm) > #endif > } > > -unsigned int get_vm_area_page_order(struct vm_struct *vm) > +unsigned int get_vm_area_page_order(const struct vm_struct *vm) > { > return vm_area_page_order(vm); > } > diff --git a/mm/vmalloc.h b/mm/vmalloc.h > index 8866ddcff6681..211869f365095 100644 > --- a/mm/vmalloc.h > +++ b/mm/vmalloc.h > @@ -12,7 +12,7 @@ void __init vmalloc_init(void); > int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end, > pgprot_t prot, struct page **pages, > unsigned int page_shift, gfp_t gfp_mask); > -unsigned int get_vm_area_page_order(struct vm_struct *vm); > +unsigned int get_vm_area_page_order(const struct vm_struct *vm); > #else > static inline void vmalloc_init(void) {} > >