Re: [PATCH 3/5] blk-mq: Drop blk_mq_ops.timeout 'reserved' arg

Hannes Reinecke
2022-06-20T09:15:38Z

On 6/17/22 12:55, John Garry wrote:
> With new API blk_mq_is_reserved_rq() we can tell if a request is from
> the reserved pool, so stop passing 'reserved' arg. There is actually
> only a single user of that arg for all the callback implementations, which
> can use blk_mq_is_reserved_rq() instead.
>
> This will also allow us to stop passing the same 'reserved' around the
> blk-mq iter functions next.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> block/blk-mq.c | 6 +++---
> block/bsg-lib.c | 2 +-
> drivers/block/mtip32xx/mtip32xx.c | 5 ++---
> drivers/block/nbd.c | 3 +--
> drivers/block/null_blk/main.c | 2 +-
> drivers/mmc/core/queue.c | 3 +--
> drivers/nvme/host/apple.c | 3 +--
> drivers/nvme/host/fc.c | 3 +--
> drivers/nvme/host/pci.c | 2 +-
> drivers/nvme/host/rdma.c | 3 +--
> drivers/nvme/host/tcp.c | 3 +--
> drivers/s390/block/dasd.c | 2 +-
> drivers/s390/block/dasd_int.h | 2 +-
> drivers/scsi/scsi_error.c | 3 +--
> drivers/scsi/scsi_priv.h | 3 +--
> include/linux/blk-mq.h | 2 +-
> 16 files changed, 19 insertions(+), 28 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer