From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F4127A929; Wed, 28 May 2025 10:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748429959; cv=none; b=ptVVQ/pcwU85GTCRDbbH4lMkabDU75MggSP2WlNT/2alj8gNmwoWYsONZHptY1wEQmSVIehu8aos+30e5DPMVPd7jd5xAnGQzEzHQ29v5d7WNDqFFZAZfOmKF3Z2q5bNExhRCQqON+cjuJbIH9oew/33tNGMomx5cTF+a63tQwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748429959; c=relaxed/simple; bh=LOybN0T1TLOSVXIdmkVCBjUOvRkBdlGj36c7pLSrCeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pVSQTwEczttF4G1N1lKDOtS6PNbFCrmjUww8j/BpEi1bs5jm8zf4iM9d6GU1ascdwmeHnYd+zZLzOXQOh/ken4asQM+yxf9dsspoCqBb8ZzWRxDGzAOJ068ElKV+eYOfrP4jv5k12Za+oqp1svJ+ky0wOuFNa83TTXWGvo5+Qeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=nGKo02LC; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="nGKo02LC" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54S2oIIR017201; Wed, 28 May 2025 10:59:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=atGrkG 5gePrus4C3QUDHBiGsvaVK564IOnIBbMfPfFQ=; b=nGKo02LC8Uj76169wWZ7Qz Uft9PLni2++8QtQRbgU8PQt6WXyb/QZA8XA70//LntwZBnHbUBt6taQBcj1a9mO9 AbdK+2e5PJavyCKo+E9+Rwbq5wxO00G/L+bAv495WDN57djjXPRc8p3744l6cbf/ 5oGt//R8QMWRVVHfTPJy+3r5LeW0aubE91LU4YZ2sEbIhua9gPujwLWynCcb1d+V iDMnfGaY65q8KJxQENE5SFyD6sCK0s4CwStiw1smMpsz/9Zdm8iPv0a3OLchJpNJ WnmFH6axl8M0nv2SbkC39uS0j3t8tua+EQfAdiW2OVbmff1U6lh0cEcgZEwUN83g == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46wgsgmb96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 May 2025 10:59:15 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54SAnokU016192; Wed, 28 May 2025 10:59:14 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46uru0q98y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 May 2025 10:59:14 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54SAxA8c48562580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 May 2025 10:59:10 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CE2020040; Wed, 28 May 2025 10:59:10 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EAA4D20043; Wed, 28 May 2025 10:59:09 +0000 (GMT) Received: from [9.87.152.254] (unknown [9.87.152.254]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 28 May 2025 10:59:09 +0000 (GMT) Message-ID: Date: Wed, 28 May 2025 12:59:09 +0200 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [kvm-unit-tests PATCH 1/2] s390x: diag10: Fence tcg and pv environments To: Thomas Huth , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, david@redhat.com, nrb@linux.ibm.com References: <20250528091412.19483-1-frankja@linux.ibm.com> <20250528091412.19483-2-frankja@linux.ibm.com> <411a5e54-e9c4-4b97-8467-38f371bfd9d5@redhat.com> Content-Language: en-US From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; keydata= xsFNBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABzSVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+wsF3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbazsFNBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABwsFfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC In-Reply-To: <411a5e54-e9c4-4b97-8467-38f371bfd9d5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zrcspmOyZT0p0AwQW9awtt0dFK1CmaA6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI4MDA4NyBTYWx0ZWRfXz7Zlld56QsOs 7KOxslrpCxG98EagsnNZmuYva3Kkk8nF9X7f8+9P5xPzoA2IZinVZaJQbZeqSA3sH4VwRYLBM7e kXyjvYTKyiBm8TnginHbNdlx9DyZwoFFWChDp2Q1GyvjPTe0yIEXrr5ENAxS/rOs+dDiOurzii2 +3dN1+qlZs3/3kZcPWpKd799qp3EulYDPf/pCoATkbH98TBdi1oFti7i9an2r08dAKvS6/0dLNq GnEheINXrn5QJOjMsHdGSGhFe++6MHShkZ7vhb6m9jIThEIiKyI4h0uHfafwuSyyWOD5QsjKUmF OmDDblyLqgGGqf/Upx0Y/r82GDZMFMITKDMu3uhCeN1o1S7KzzrqiiIpnQc0Q+dNNJqGTe6e4yz UJNivcvNxePIDYDrRTwoK+7r4UKu/BIshcMB8MMMO59o8+MyszqDkPaHNe3FIyoyNPEO5RBa X-Authority-Analysis: v=2.4 cv=bZRrUPPB c=1 sm=1 tr=0 ts=6836ec83 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=Niv4UAXYI8Wio8mRCwgA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: zrcspmOyZT0p0AwQW9awtt0dFK1CmaA6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-28_05,2025-05-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 mlxscore=0 suspectscore=0 impostorscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505280087 On 5/28/25 11:55 AM, Thomas Huth wrote: > On 28/05/2025 11.13, Janosch Frank wrote: >> Diag10 isn't supported under either of these environments so let's >> make sure that the test bails out accordingly. >> >> Signed-off-by: Janosch Frank >> --- >> s390x/diag10.c | 15 +++++++++++++++ >> s390x/unittests.cfg | 1 + >> 2 files changed, 16 insertions(+) >> >> diff --git a/s390x/diag10.c b/s390x/diag10.c >> index 579a7a5d..00725f58 100644 >> --- a/s390x/diag10.c >> +++ b/s390x/diag10.c >> @@ -9,6 +9,8 @@ >> */ >> >> #include >> +#include >> +#include >> #include >> #include >> #include >> @@ -95,8 +97,21 @@ static void test_priv(void) >> int main(void) >> { >> report_prefix_push("diag10"); >> + >> + if (host_is_tcg()) { >> + report_skip("Test unsupported under TCG"); >> + goto out; >> + } >> + if (uv_os_is_guest()) { >> + report_skip("Test unsupported under PV"); >> + goto out; >> + } >> + >> test_prefix(); >> test_params(); >> test_priv(); > > Would it make sense to run test_priv() at least for TCG/PV, too? Could do but I think such tests should go into a general diag test. The KVM code tests priv before checking the subcode and going into the specific handler. So if the priv test on diag44 succeeds, then it should succeed on any other diag even if it's not implemented. Under PV we'd be testing HW and/or FW instead of QEMU/KVM.