Re: [kvm-unit-tests PATCH 1/3] riscv: Drop mstrict-align

Thomas Huth
2024-09-04T06:16:02Z

On 03/09/2024 18.30, Andrew Jones wrote:
> The spec says unaligned accesses are supported, so this isn't required
> and clang doesn't support it. A platform might have slow unaligned
> accesses, but kvm-unit-tests isn't about speed anyway.
>
> Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
> ---
> riscv/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/riscv/Makefile b/riscv/Makefile
> index 179a373dbacf..2ee7c5bb5ad8 100644
> --- a/riscv/Makefile
> +++ b/riscv/Makefile
> @@ -76,7 +76,7 @@ LDFLAGS += -melf32lriscv
> endif
> CFLAGS += -DCONFIG_RELOC
> CFLAGS += -mcmodel=medany
> -CFLAGS += -mstrict-align
> +#CFLAGS += -mstrict-align
> CFLAGS += -std=gnu99
> CFLAGS += -ffreestanding
> CFLAGS += -O2

Reviewed-by: Thomas Huth <thuth@redhat.com>