Re: [PATCH v3 1/1] KVM: s390: vsie: clarifications on setting the APCB

Pierre Morel
2023-02-17T08:21:26Z

On 2/16/23 14:04, David Hildenbrand wrote:
> On 14.02.23 13:28, Pierre Morel wrote:
>> The APCB is part of the CRYCB.
>> The calculation of the APCB origin can be done by adding
>> the APCB offset to the CRYCB origin.
>>
>> Current code makes confusing transformations, converting
>> the CRYCB origin to a pointer to calculate the APCB origin.
>>
>> Let's make things simpler and keep the CRYCB origin to make
>> these calculations.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> ---
>
> Much better
>
> Acked-by: David Hildenbrand <david@redhat.com>
>

Thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen