From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.110.172]:56522 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727399AbfKLGwe (ORCPT ); Tue, 12 Nov 2019 01:52:34 -0500 Subject: Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers References: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com> <20191112062951.GA100264@gmail.com> From: Anshuman Khandual Message-ID: Date: Tue, 12 Nov 2019 12:22:45 +0530 MIME-Version: 1.0 In-Reply-To: <20191112062951.GA100264@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org On 11/12/2019 11:59 AM, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > >> +config DEBUG_VM_PGTABLE >> + bool "Debug arch page table for semantics compliance" >> + depends on MMU >> + depends on DEBUG_VM >> + depends on ARCH_HAS_DEBUG_VM_PGTABLE >> + help >> + This option provides a debug method which can be used to test >> + architecture page table helper functions on various platforms in >> + verifying if they comply with expected generic MM semantics. This >> + will help architecture code in making sure that any changes or >> + new additions of these helpers still conform to expected >> + semantics of the generic MM. >> + >> + If unsure, say N. > > Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages, > why not make this 'default y' to maximize testing coverage? The code size > increase should be minimal, and DEBUG_VM increases size anyway. Sure, will do. > > Other than that this looks good to me: > > Reviewed-by: Ingo Molnar Thank you. > > Thanks, > > Ingo >