Re: [kvm-unit-tests PATCH v5 3/4] s390x: lib: add SPX and STPX instruction wrapper

Thomas Huth
2020-01-09T12:55:42Z

On 09/01/2020 12.36, Claudio Imbrenda wrote:
> On Wed, 8 Jan 2020 19:58:27 +0100
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 08/01/2020 17.13, Claudio Imbrenda wrote:
>>> Add a wrapper for the SET PREFIX and STORE PREFIX instructions, and
>>> use it instead of using inline assembly everywhere.
>>
>> Either some hunks are missing in this patch, or you should update the
>> patch description and remove the second part of the sentence ? ... at
>> least I did not spot the changes where you "use it instead of using
>> inline assembly everywhere".
>
>
> oops sorry, the description is a little misleading. I meant
> everywhere in the specific unit test, not everywhere in the whole
> source tree.
>
> I should either change the description or actually patch the remaining
> users of inline assembly to use the wrappers instead. (any preference?)

No preferences from my side. If you don't want/have to respin, the patch
description could be fixed when picking up the patch, otherwise simply
do whatever you prefer in v6.

Thomas