Re: [RFC PATCH v3 2/2] KVM: s390: Extend the USER_SIGP capability

Janosch Frank
2021-11-11T16:17:02Z

On 11/10/21 21:33, Eric Farman wrote:
> With commit 2444b352c3ac ("KVM: s390: forward most SIGP orders to user
> space") we have a capability that allows the "fast" SIGP orders (as
> defined by the Programming Notes for the SIGNAL PROCESSOR instruction in
> the Principles of Operation) to be handled in-kernel, while all others are
> sent to userspace for processing.
>
> This works fine but it creates a situation when, for example, a SIGP SENSE
> might return CC1 (STATUS STORED, and status bits indicating the vcpu is
> stopped), when in actuality userspace is still processing a SIGP STOP AND
> STORE STATUS order, and the vcpu is not yet actually stopped. Thus, the
> SIGP SENSE should actually be returning CC2 (busy) instead of CC1.
>
> To fix this, add another CPU capability, dependent on the USER_SIGP one,
> and two associated IOCTLs. One IOCTL will be used by userspace to mark a
> vcpu "busy" processing a SIGP order, and cause concurrent orders handled
> in-kernel to be returned with CC2 (busy). Another IOCTL will be used by
> userspace to mark the SIGP "finished", and the vcpu free to process
> additional orders.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> arch/s390/include/asm/kvm_host.h | 2 ++
> arch/s390/kvm/kvm-s390.c | 29 +++++++++++++++++++++++++++++
> arch/s390/kvm/kvm-s390.h | 16 ++++++++++++++++
> arch/s390/kvm/sigp.c | 10 ++++++++++
> 4 files changed, 57 insertions(+)
>
> diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h
> index a604d51acfc8..c93271557de3 100644
> --- a/arch/s390/include/asm/kvm_host.h
> +++ b/arch/s390/include/asm/kvm_host.h
> @@ -748,6 +748,7 @@ struct kvm_vcpu_arch {
> bool skey_enabled;
> struct kvm_s390_pv_vcpu pv;
> union diag318_info diag318_info;
> + atomic_t sigp_busy;
> };
>
> struct kvm_vm_stat {
> @@ -941,6 +942,7 @@ struct kvm_arch{
> int user_sigp;
> int user_stsi;
> int user_instr0;
> + int user_sigp_busy;
> struct s390_io_adapter *adapters[MAX_S390_IO_ADAPTERS];
> wait_queue_head_t ipte_wq;
> int ipte_lock_count;
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 5f52e7eec02f..06d188dd2c89 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -564,6 +564,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> case KVM_CAP_S390_VCPU_RESETS:
> case KVM_CAP_SET_GUEST_DEBUG:
> case KVM_CAP_S390_DIAG318:
> + case KVM_CAP_S390_USER_SIGP_BUSY:
> r = 1;
> break;
> case KVM_CAP_SET_GUEST_DEBUG2:
> @@ -706,6 +707,15 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap)
> kvm->arch.user_sigp = 1;
> r = 0;
> break;
> + case KVM_CAP_S390_USER_SIGP_BUSY:
> + r = -EINVAL;
> + if (kvm->arch.user_sigp) {
> + kvm->arch.user_sigp_busy = 1;
> + r = 0;
> + }
> + VM_EVENT(kvm, 3, "ENABLE: CAP_S390_USER_SIGP_BUSY %s",
> + r ? "(not available)" : "(success)");
> + break;
> case KVM_CAP_S390_VECTOR_REGISTERS:
> mutex_lock(&kvm->lock);
> if (kvm->created_vcpus) {
> @@ -4825,6 +4835,25 @@ long kvm_arch_vcpu_async_ioctl(struct file *filp,
> return -EINVAL;
> return kvm_s390_inject_vcpu(vcpu, &s390irq);
> }
> + case KVM_S390_VCPU_SET_SIGP_BUSY: {
> + int rc;
> +
> + if (!vcpu->kvm->arch.user_sigp_busy)
> + return -EFAULT;

Huh?
This should be EINVAL, no?

> +
> + rc = kvm_s390_vcpu_set_sigp_busy(vcpu);
> + VCPU_EVENT(vcpu, 3, "SIGP: CPU %x set busy rc %x", vcpu->vcpu_id, rc);
> +
> + return rc;
> + }
> + case KVM_S390_VCPU_RESET_SIGP_BUSY: {
> + if (!vcpu->kvm->arch.user_sigp_busy)
> + return -EFAULT;

Same

> +
> + VCPU_EVENT(vcpu, 3, "SIGP: CPU %x reset busy", vcpu->vcpu_id);
> + kvm_s390_vcpu_clear_sigp_busy(vcpu);
> + return 0;
> + }
> }
> return -ENOIOCTLCMD;
> }
> diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h
> index c07a050d757d..54371cede485 100644
> --- a/arch/s390/kvm/kvm-s390.h
> +++ b/arch/s390/kvm/kvm-s390.h
> @@ -82,6 +82,22 @@ static inline int is_vcpu_idle(struct kvm_vcpu *vcpu)
> return test_bit(vcpu->vcpu_idx, vcpu->kvm->arch.idle_mask);
> }
>
> +static inline bool kvm_s390_vcpu_is_sigp_busy(struct kvm_vcpu *vcpu)
> +{
> + return (atomic_read(&vcpu->arch.sigp_busy) == 1);
> +}
> +
> +static inline bool kvm_s390_vcpu_set_sigp_busy(struct kvm_vcpu *vcpu)
> +{
> + /* Return zero for success, or -EBUSY if another vcpu won */
> + return (atomic_cmpxchg(&vcpu->arch.sigp_busy, 0, 1) == 0) ? 0 : -EBUSY;
> +}
> +
> +static inline void kvm_s390_vcpu_clear_sigp_busy(struct kvm_vcpu *vcpu)
> +{
> + atomic_set(&vcpu->arch.sigp_busy, 0);
> +}
> +
> static inline int kvm_is_ucontrol(struct kvm *kvm)
> {
> #ifdef CONFIG_KVM_S390_UCONTROL
> diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
> index 5ad3fb4619f1..a37496ea6dfa 100644
> --- a/arch/s390/kvm/sigp.c
> +++ b/arch/s390/kvm/sigp.c
> @@ -276,6 +276,10 @@ static int handle_sigp_dst(struct kvm_vcpu *vcpu, u8 order_code,
> if (!dst_vcpu)
> return SIGP_CC_NOT_OPERATIONAL;
>
> + if (kvm_s390_vcpu_is_sigp_busy(dst_vcpu)) {
> + return SIGP_CC_BUSY;
> + }
> +
> switch (order_code) {
> case SIGP_SENSE:
> vcpu->stat.instruction_sigp_sense++;
> @@ -411,6 +415,12 @@ int kvm_s390_handle_sigp(struct kvm_vcpu *vcpu)
> if (handle_sigp_order_in_user_space(vcpu, order_code, cpu_addr))
> return -EOPNOTSUPP;
>
> + /* Check the current vcpu, if it was a target from another vcpu */
> + if (kvm_s390_vcpu_is_sigp_busy(vcpu)) {
> + kvm_s390_set_psw_cc(vcpu, SIGP_CC_BUSY);
> + return 0;
> + }
> +
> if (r1 % 2)
> parameter = vcpu->run->s.regs.gprs[r1];
> else
>