From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793304993; b=Jw7wVk6KSNaGbYgyOU86zFpe1qE5xPTm/jWaOO5zNOIVrtElvVcSwnuGddfT+wQ+CTm3 5fchwTdfqglbBcw4Ty/vTmlxYLpQwqu/5ETCqmVxlnzE3/G1PY7pJrKpgnAvn8OTOvLTD qQm3VOqdwnTWMN3QHMTQOLpENOvsoO6BKCe/sE2BWrtTh4jftd8LstEvQBZfDhkUc0cx5 V/lAtu6yHBTZkdWA4L/gAKFfrCKObcJXc98nYB6E0R94imQelD3ph/9uaTrM03Z0L/sZ1 Kn83VVSUkpQlRc1DIMPv1SLWsI8LsEw9drqw5dq4ZBhyw/le0zoGekzmEI4/DCJk0LA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793304993; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=kmE/jbnenkA14GSAY+4bG6WX1auQKnmiCwXu85yaVLY=; b=UrE4HHEyUtL3FY5WbhQuizXXJ+W4js+xyUM0b5KRb4SutyGxupSvPFc8cVKM2ZZPCrFF wWOYn+7Fg+j/CgXTgST5t83mAgZcWLk1AAHBwz1kdfMBi5TB20OhVriquuiq3JMRY7cHT xbfuH6oP7wpb7nNykMWoV9U5twrFrbWh+HkUomeSII0D5gDxvtS0+N4WEs0dbqtOdMaOd +5DLGMUFeQDqHgXT95XNVnuJS4oENDPYfc2VFrX86dU0tjgi8oSbmcD62jvoiOxCeVH31 WKfqyEDtqwvnZ/S3r5FriRQxaxYwXH1THVkLAlNyEtG0H5yB7UeUlX7dsjHnYGnsXsA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VANYQY+w; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19702606A31A for ; Thu, 29 Oct 2026 20:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VANYQY+w Received: by smtp.kernel.org (Postfix) with ESMTPSA id 023571F01816; Thu, 29 Oct 2026 20:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793304992; bh=kmE/jbnenkA14GSAY+4bG6WX1auQKnmiCwXu85yaVLY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VANYQY+w/42lGsFmlooslsEiw9JFc6ggs8i13Ax3xbPVv48Wcd3YnA5C3zdYUxZlA ht+G/YO277h7kz6KprefxsDL7/xqv/c8y9VaV2WWnbVwXiixmqQAQHrVivKKpdLafv u4672KY40B1abp/4jW9gHfPamFJr9PSuSg9SlwPdVRR2QVaRSPWhbRkPRHpXiUgOsR dIa1Bymab1385vtrIR+JYDyiQxoFKj5azvQYp+kl1iY5SfpxCHNrRFKz8VcWoYqIh2 gHtSt2a34QME5PDcRWHLs3im17/qRTaD6F0dbH7VV5unnMyPWEFX3PdMF8R62c7C3y R1OA903v34TgA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 07/15] hugetlbfs: fix unmapping folios from private VMAs Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= Cc: linux-s390@vger.kernel.org, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261028-fixes_hugetlb-v1-7-a0a033db180f@kernel.org> References: <20261028-fixes_hugetlb-v1-0-a0a033db180f@kernel.org> <20261028-fixes_hugetlb-v1-7-a0a033db180f@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 29 Oct 2026 20:16:31 +0000 X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > From: Josef Bacik >=20 > hugetlb_unmap_file_folio() assumes vm_private_data points to a struct > hugetlb_vma_lock when hugetlb_vma_trylock_write() fails. Since hugetlb VMA > locking was extended to private VMAs, this can also happen when > vm_private_data contains a resv_map pointer; treating it as a > hugetlb_vma_lock corrupts memory and can cause crashes or hangs. >=20 > Only take the VMA lock when a shareable lock exists, as additional locking > is only needed for PMD table sharing. The fault mutex and i_mmap_rwsem > already provide the required protection for private VMAs. >=20 > Fix generated by an LLM and sent by Josef Bacik in private. >=20 > Fixes: bf4916922c60 ("hugetlbfs: extend hugetlb_vma_lock to private VMAs") > Cc: stable@kernel.org > Tested-by: Daehyeon Ko <4ncienth@gmail.com> > Signed-off-by: Josef Bacik > [ david: simplify description and comment ] > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261028-fixes_huge= tlb-v1-0-a0a033db180f@kernel.org?part=3D7