From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794855909; b=W4tyGedJr8ziqggkw1pqvpClnW4XZM39H5VI7sTmc6+zPJ3Wu0aGywoDtAqQctDZ0Hv5 tEfgyR7jf+KdT0t2hTnydRhspoIMDkDCCpO9dZG4ISb2Xlg5v7iXLnYS/r4dPYcsO25Sf jQ0dOXNS47YVm5mxoaWB6jrY2jPzeADcxNHze84CgTJbKAMkOd/GV/+A0+63JI8DeXq52 vhzVeJuTV0U5W2coBw3QoG5nFJFVYuX1l7OANBsKLh6PmYzI/u2SBiLWDV2qqaj8gMMNq 31/wSiLxvNPB9H6uZnuqtRW04KX9mDik5enshDM8ooasZQ0mzPywObKeor5spbAhfeg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794855909; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=aFSNzfbGYOgrkUbjT7M8lnsAJHBbJ+RSjq5FQmp4CMg=; b=kx1M9fpLRk/BKFpBFJaBeHC80sYWp04E/7lt8ooefA+mwweVJjwV2wR9R/u0/kYwQMSA kTGc+CpBWr9M36Kj+ucoXAyTZETWY8LgEg/aqMhHJkuJX7Qt5OtlvnKvritPCQ5GPIVJo KZ2q2/KEOnpffI0WuRhgq0V3m5iYFEgWf5MLgaWfNHTcvJesI6d3FI7EDuMxlDBBUV67k bsc6Ql662Pa2G3OjhwpMRysv0BvHVhTdshyAs+SnWjKgmpqefCE06Y1cW9PGN+2kIy7yk WDuY/4d3GjAWE06c9YyhWZV9Cdq2qq+Ljz+ZFp00ReMZ+fky0hsLgr9wAdq8byu+XGQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EXAIVFzQ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610EE606A33E for ; Mon, 16 Nov 2026 19:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EXAIVFzQ Received: by smtp.kernel.org (Postfix) with ESMTPSA id C08931F000C9; Mon, 16 Nov 2026 19:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794855909; bh=aFSNzfbGYOgrkUbjT7M8lnsAJHBbJ+RSjq5FQmp4CMg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EXAIVFzQb9DlLLOTTYvxCXQXDAMuJG52L43vXugkaFY/hzytSymFym9tQwMIiCLnO QkNtnXma2Mh0Eklnyzxkkp+c2vemnx3mWpY1Xnoi3cAktivt33sy92Gja3HUZMiyT+ XgUakjqhv4QIkvDCFScOQmOutXwtn04NOxb1Vvvqstwv18klsLMZD6ID+Wni/hh1nt HqHuf5bFSxDKyv9WMkzTPg5sVO4t+d5C7OPDIz6haIYPttuBE/hsOukuD8uIxS5b/Y qnY2DY0Rx6seugi5fTvXgdSYyGG0UZFz/f1d+Kx5BKklqV316uF27Nnw33InY8xtB/ ffW4HmYIBqhcw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 07/15] hugetlbfs: fix unmapping folios from private VMAs Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= Cc: linux-s390@vger.kernel.org, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261116-fixes_hugetlb-v2-7-4dd9e94ea9ac@kernel.org> References: <20261116-fixes_hugetlb-v2-0-4dd9e94ea9ac@kernel.org> <20261116-fixes_hugetlb-v2-7-4dd9e94ea9ac@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2026 19:05:08 +0000 X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > From: Josef Bacik >=20 > hugetlb_unmap_file_folio() assumes vm_private_data points to a struct > hugetlb_vma_lock when hugetlb_vma_trylock_write() fails. Since hugetlb VMA > locking was extended to private VMAs, this can also happen when > vm_private_data contains a resv_map pointer; treating it as a > hugetlb_vma_lock corrupts memory and can cause crashes or hangs. >=20 > Only take the VMA lock when a shareable lock exists, as additional locking > is only needed for PMD table sharing. The fault mutex and i_mmap_rwsem > already provide the required protection for private VMAs. >=20 > Fix generated by an LLM and sent by Josef Bacik in private. >=20 > Fixes: bf4916922c60 ("hugetlbfs: extend hugetlb_vma_lock to private VMAs") > Cc: stable@kernel.org > Tested-by: Daehyeon Ko <4ncienth@gmail.com> > Signed-off-by: Josef Bacik > [ david: simplify description and comment ] > Acked-by: Muchun Song > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261116-fixes_huge= tlb-v2-0-4dd9e94ea9ac@kernel.org?part=3D7