From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794855912; b=2vwMaFQ8G4OwSU46DmtKGg/HHKzH/Vsrndg+G+rfh6OPj8YURlUsCyBm2xX8rIgkRXzs 7azepvDeTm1wnqX15MTXRVbwVAyEEaBIw/KVGEDXhs8SrZSDU7Gpjeo09Kc+lWOzNttcg zw52z9hhaXsBkPbLp9NPHqBZeL8G3ttdSaxaLJ71dh7JN1QsUBQWDrZVbGpgB+K9ogxCW kajgXFDXWTQisN9U8BFJqzgcOTudB/lJfeMBkqgDIYnHJeh6308asP73EH4FVGjemHIOg XaJyv/hE4SJ78071lr7TOCqJ5yvp59+NV9HUVjKJWAU7GmOPrlEe2ii134Z+b4aw3Lw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794855912; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=CiGCANF+Qs74asECfnBOPCPgHoNSEyQsFa2Z0ig7BsA=; b=iXONUOxE0yEPEIsuY4UEF9TeSFgUFmYTzDZJgBtLYcrpNfCWBWZ9UbhOzpzLBgZeU7Yv gWk1GEXY7vEfTHsHfLSJNyHzKqR5dV6fMUUXSEny9xQlQTL0w+bTTABOkNbVhPq5OMJzD hul+NvkuYlzHZ/IffOvY4HAlk271dCwmmtIu2JdIsvOJ+ga5860Ngf0QbzE7uo8wD+A1q c+yCCxCv55PNMF3zp/FBbIhoo/5w8Y68NeRaTp9KF5HeI3EPRDa8ujt9wSgFgaKPeTumX 1Z9tWaiVyddklHE0o34Jv+i5COxO6H2fhZPfOTvm/9Wy6UZG3lWa32Y7O9SQIHsFgqQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OUe5qK35; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75CD5606A888 for ; Mon, 16 Nov 2026 19:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OUe5qK35 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2CBD1F000C4; Mon, 16 Nov 2026 19:05:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794855912; bh=CiGCANF+Qs74asECfnBOPCPgHoNSEyQsFa2Z0ig7BsA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OUe5qK35tg8HAAdHBPtJe6rjx546UvQjLvN56ITbpXhdoeqMnb1tpRGBSANGdZp7W vtfMfB0c8UOpMD243koaOTBCXvupE/6Vv79Vv8IO2MHgrbLNALADtvhUZL0RPDhFEP So49JF9ulBOO0bBOePMP3Rn8UUMTxaSDrnGSzaJCFzCssunYVSJrVUcNFjsXRXYU+V 7L2DigwlgpQ8N1ShvmzusKl0shG9y+kT48cykCe1rVAMDwfpS2PvYfpikI3E9snQcX QGHQQRTMWNIO7zqObm4O+YXPXeytZfrJ01x9bdTB25iPNJvQryyL/0eF3XQWORrN34 DkdqWVTE7ja2Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 11/15] hugetlbfs: do not grow a sealed file in mmap() Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= Cc: linux-s390@vger.kernel.org, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261116-fixes_hugetlb-v2-11-4dd9e94ea9ac@kernel.org> References: <20261116-fixes_hugetlb-v2-0-4dd9e94ea9ac@kernel.org> <20261116-fixes_hugetlb-v2-11-4dd9e94ea9ac@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2026 19:05:11 +0000 X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > From: Chris Mason >=20 > hugetlbfs_file_mmap() grows a file when a writable mapping extends beyond > EOF. We are missing seal checks similar to hugetlbfs_setattr() and > hugetlbfs_fallocate(), allowing a user to grow a file that has F_SEAL_GROW > set. >=20 > To fix it, skip the resize when F_SEAL_GROW is set; mmap() still succeeds > without growing the file. >=20 > We currently also allow CoW mappings to grow a file. Disallowing this, > maybe even only for read-only file descriptors, could break existing > userspace, so we have to be more careful. QEMU's file backend is an > example user that might rely on such things, and would suddenly start > getting SIGBUS when faulting in memory outside EOF. >=20 > So be careful and focus on F_SEAL_GROW for now. >=20 > Fix generated by an LLM and sent by Chris Mason in private. >=20 > Fixes: ff62a3421044 ("hugetlb: implement memfd sealing") > Cc: stable@kernel.org > Signed-off-by: Chris Mason > [ david: drop comment; simplify+extend description ] > Acked-by: Muchun Song > Tested-by: Gregory Price (Meta) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261116-fixes_huge= tlb-v2-0-4dd9e94ea9ac@kernel.org?part=3D11